Skip to content

Commit 1716691

Browse files
Copilotavikivity
andcommitted
Remove SEASTAR_MODULE definition - not needed
SEASTAR_MODULE is not needed because all Seastar headers are included in the module purview (after 'export module seastar;'). Everything declared in the module purview is automatically part of the module's interface and exported, including: - All seastar namespace symbols - std::hash specializations in namespace std The SEASTAR_MODULE_EXPORT macros in headers now expand to nothing, but this is fine - the declarations are still exported because they're in the module purview. The explicit 'export' keywords were redundant. This simplifies the build: no special compile definitions needed for module builds. Co-authored-by: avikivity <[email protected]>
1 parent ae8e26c commit 1716691

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,6 @@ target_compile_definitions (seastar-module
9999
SEASTAR_SCHEDULING_GROUPS_COUNT=${Seastar_SCHEDULING_GROUPS_COUNT}
100100
PRIVATE
101101
${Seastar_PRIVATE_COMPILE_DEFINITIONS})
102-
# Define SEASTAR_MODULE only for the module interface file, not implementation files
103-
set_source_files_properties (seastar.cppm
104-
PROPERTIES
105-
COMPILE_DEFINITIONS "SEASTAR_MODULE")
106102
target_compile_options (seastar-module
107103
PUBLIC
108104
-U_FORTIFY_SOURCE)

0 commit comments

Comments
 (0)