fix(mobile): buffer width/height referenced after recycling (immich-app#26415)

mertalev · web-flow · commit 1d25267f2240 · 2026-02-21T09:41:44.000-06:00
recycle after getters
diff --git a/mobile/android/app/src/main/kotlin/app/alextran/immich/images/LocalImagesImpl.kt b/mobile/android/app/src/main/kotlin/app/alextran/immich/images/LocalImagesImpl.kt
@@ -48,7 +48,6 @@ fun Bitmap.toNativeBuffer(): Map<String, Long>  {
   try {
     val buffer = NativeBuffer.wrap(pointer, size)
     copyPixelsToBuffer(buffer)
-    recycle()
     return mapOf(
       "pointer" to pointer,
       "width" to width.toLong(),
@@ -57,8 +56,9 @@ fun Bitmap.toNativeBuffer(): Map<String, Long>  {
     )
   } catch (e: Exception) {
     NativeBuffer.free(pointer)
-    recycle()
     throw e
+  } finally {
+    recycle()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ fun Bitmap.toNativeBuffer(): Map<String, Long> {`
`48`	`48`	`try {`
`49`	`49`	`val buffer = NativeBuffer.wrap(pointer, size)`
`50`	`50`	`copyPixelsToBuffer(buffer)`
`51`		`- recycle()`
`52`	`51`	`return mapOf(`
`53`	`52`	`"pointer" to pointer,`
`54`	`53`	`"width" to width.toLong(),`
`@@ -57,8 +56,9 @@ fun Bitmap.toNativeBuffer(): Map<String, Long> {`
`57`	`56`	`)`
`58`	`57`	`} catch (e: Exception) {`
`59`	`58`	`NativeBuffer.free(pointer)`
`60`		`- recycle()`
`61`	`59`	`throw e`
	`60`	`+ } finally {`
	`61`	`+ recycle()`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`