Fix Grid View so that Action is populated when item is selected. (#4595)

Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com>
Co-authored-by: Paul Bob <paul.ionut.bob@gmail.com>

Author: rctneil

app/components/avo/view_types/grid_component.html.erb

@@ -6,6 +6,8 @@
     tabindex: (@reflection.present? ? nil : "-1"),
     data: {
       component_name: self.class.to_s.underscore,
+      controller: "item-select-all",
+      resource_name: @resource.model_key,
       selected_resources_name: @resource.model_key,
       selected_resources: [],
       **(@reflection.present? ? {} : {"content-focus": ""}),

app/javascript/js/controllers/item_select_all_controller.js

@@ -22,6 +22,8 @@ export default class extends Controller {
   }
 
   elementAttributeValueChanged(element) {
+    if (!this.hasCheckboxTarget) return
+
     // Check if anything is selected.
     const selectedResources = JSON.parse(element.dataset.selectedResources)
     // If all are selected, mark the checkbox as checked.
@@ -47,7 +49,10 @@ export default class extends Controller {
 
   deselectAll() {
     this.itemCheckboxTargets.forEach((checkbox) => checkbox.checked && checkbox.click())
-    this.checkboxTarget.checked = false
+
+    if (this.hasCheckboxTarget) {
+      this.checkboxTarget.checked = false
+    }
 
     if (this.selectAllEnabled()) {
       this.selectAllOverlay(false)
@@ -73,7 +78,10 @@ export default class extends Controller {
     let allSelected = true
     // eslint-disable-next-line no-return-assign
     this.itemCheckboxTargets.forEach((checkbox) => allSelected = allSelected && checkbox.checked)
-    this.checkboxTarget.checked = allSelected
+
+    if (this.hasCheckboxTarget) {
+      this.checkboxTarget.checked = allSelected
+    }
 
     if (this.selectAllEnabled()) {
       this.selectAllOverlay(allSelected)

spec/system/avo/group_3/actions_spec.rb

@@ -484,6 +484,33 @@
       click_on "Actions"
       expect(page.find("a", text: "Toggle post published")["data-disabled"]).to eq "true"
     end
+
+    # Regression for https://github.com/avo-hq/avo/pull/4595 — selected grid
+    # records must reach the action (confirmation message + handle query).
+    it "runs an action with the selected records on the products grid" do
+      product = create :product, title: "Grid Product One"
+
+      visit avo.resources_products_path
+
+      grid_component = find(
+        "[data-component-name=\"avo/index/grid_item_component\"]" \
+        "[data-resource-name=\"products\"]" \
+        "[data-record-id=\"#{product.to_param}\"]"
+      )
+
+      within grid_component do
+        grid_component.hover
+        find("input[type=checkbox]").click
+      end
+
+      open_panel_action(action_name: "Show products")
+
+      expect(page).to have_text "Selected products: Grid Product One"
+
+      run_action
+
+      expect(page).to have_text "Selected products: Grid Product One"
+    end
   end
 
   describe "record assignment" do