refactor: via_resource_class param
#3383
Conversation
|
Code Climate has analyzed commit f1f13b4 and detected 0 issues on this pull request. View more on Code Climate. |
|
Considered using:
I found the simpler solution is to def get_resource(resource)
# Already do the job
resource = "Avo::Resources::#{resource}" unless resource.to_s.starts_with?("Avo::Resources::")
...
end |
There was a problem hiding this comment.
Thank you for this contribution @thiagoyoussef
The idea behind refactoring via_resource_class is to make it cleaner on the params, while keeping the namespace structure.
There should be a clear difference on params between Avo::Resources::Link and Avo::Resource::Course::Link.
Unfortunately, this approach loses all namespace context.
This issue needs some research and some discussion around the implementation before actually coding.
There are some issues marked as "Good first issue" if you want to contribute on something where you can jump directly to the development phase.
|
Closing this one until we research a proper approach. Thank you again @thiagoyoussef for all the effort on this one |
|
100%, I didn't think about the context when there is |
Description
Fixes #2100
Checklist:
Screenshots & recording