Missing data attributes/targets from belongs_to field

[lucasgeron]

Describe the bug

Given a field as: :belongs_to,
When rendering the edit form,
Then the data attributes from the Input are missing,
And when provide some data attribute manually
Then the missing data attributes/targets are added as expected

Reproduction repository for the bug

N/A

Steps to use in the reproduction repository

Steps to reproduce:

field :some_field,
      as: :belongs_to,
      nullable: true,
      searchable: true,
      can_create: false,
      hide_on: %i[index],
      html: lambda {
        edit do
          wrapper do
            classes do
               'hidden' unless record.some_condition?
            end
          end
          input do # comment this block for actual behavior, uncomment for expected behavior
            data do
              { foo: 'bar' } 
            end
          end
        end
      }

Expected behavior & Actual behavior

Actual Behavior
Data attributes are missing, and are set only if set some data-attribute were set manually.

Expected behavior
Have the data attributes without needed to set it manually.

System configuration

Avo version:
3.2.1

Rails version:
8.1.2

Ruby version:
3.4.7

License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Screenshots or screen recordings

When there is a custom data set manually

When there is no custom data defined

Additional context

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)

[linear]

AVO-1168

[lucasgeron]

Related to this same issue, there is a similar case related to searchable: true|false option....

When the field has searchable: true after select some value, the component renders a clear button with data attributes...

but when the field isn't searchable, or this option is set to false, there is no data-attributes linked to the clear button...

This implies that we can't clear programmatically, like:

this.SomeWrapperTarget.querySelector('[data-search-target="clearButton"]')?.click();

---

edit:
for this specific case, we can do it using:

this.amountValueTagsWrapperTarget.querySelector('tag .tagify__tag__removeBtn')?.click();

but this add more complexity to the controllers... maybe the 'clear' should have a default data target... to be accessible globally

[github-actions]

This issue has been marked as stale because there was no activity for the past 15 days.

[Paul-Bob]

Thanks for reporting this. The default data attributes should always be present unless the keys are intentionally overridden. We will have a look and fix this issue when we get the chance

[github-actions]

This issue has been marked as stale because there was no activity for the past 15 days.