Merge pull request #4059 from richtja/static-check-submodule

 Static checks: introduce usage of "avocado-static-checks" project

Author: richtja

.github/workflows/ci.yml

@@ -17,6 +17,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
+          submodules: true
       - name: Check signed-off-by
         run: ./selftests/signedoff-check.sh
       - name: Install make

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "avocado-static-checks"]
+	path = avocado-static-checks
+	url = https://github.com/avocado-framework/avocado-static-checks

CODING_STYLE

@@ -15,7 +15,7 @@ Base coding style
 
 The coding style for all Python code is the one enforced by black (see
 https://black.readthedocs.io/en/stable/the_black_code_style/).  The
-selftests/style.sh script can be used to verify the code style matches.
+avocado-static-checks/check-style script can be used to verify the code style matches.
 
 
 Variable names and UpPeR cAsE

Makefile

@@ -46,8 +46,8 @@ requirements: pip
 	- $(PYTHON) -m pip install -r requirements.txt
 
 check:
-	./selftests/style.sh
-	./selftests/isort.sh
+	./avocado-static-checks/check-style
+	./avocado-static-checks/check-import-order
 	inspekt lint --disable W,R,C,E0203,E0601,E1002,E1101,E1102,E1103,E1120,F0401,I0011,E1003,W605,I1101 --exclude avocado-libs,scripts/github
 	pylint --errors-only --disable=all --enable=spelling --spelling-dict=en_US --spelling-private-dict-file=spell.ignore *
 

avocado-static-checks

@@ -84,7 +84,6 @@ def arch_listing(config, guest_name_parser=None):
 
 
 class NotAvocadoVTTest(object):
-
     """
     Not an Avocado-vt test (for reporting purposes)
     """
@@ -93,7 +92,6 @@ class NotAvocadoVTTest(object):
 if AVOCADO_LOADER_AVAILABLE:
 
     class VirtTestLoader(loader.TestLoader, DiscoveryMixIn):
-
         """
         Avocado loader plugin to load avocado-vt tests
         """

avocado_vt/loader.py

@@ -36,7 +36,6 @@
 
 
 class VirtTestOptionsProcess(object):
-
     """
     Pick virt test options and parse them to get to a cartesian parser.
     """

avocado_vt/options.py

@@ -196,7 +196,6 @@ def _str_or_none(arg):
 
 
 class VTRun(CLI):
-
     """
     Avocado VT - legacy virt-test support
     """

avocado_vt/plugins/vt.py

@@ -25,7 +25,6 @@
 
 
 class VTBootstrap(CLICmd):
-
     """
     Avocado VT - implements the 'vt-bootstrap' subcommand
     """

avocado_vt/plugins/vt_bootstrap.py

@@ -19,7 +19,6 @@
 
 
 class LockCreationError(Exception):
-
     """
     Represents any error situation when attempting to create a lock file
     """
@@ -28,7 +27,6 @@ class LockCreationError(Exception):
 
 
 class OtherProcessHoldsLockError(Exception):
-
     """
     Represents a condition where other process has the lock
     """