Allow for configurable extra vm dump checks for present/absent messages

The typical use for this is when dumping extra logs and wanting to
make sure certain information is always present (e.g. startup, etc.)
and certain information is always absent (e.g. segfaults, etc.).

It makes use of aexpect's linux ops as well as pattern matrching
for grepping the expected or unexpected messages.

Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>

Author: pevogam

virttest/env_process.py

@@ -12,6 +12,7 @@
 import time
 
 import six
+from aexpect import ops_linux as ops
 from aexpect import remote
 from avocado.core import exceptions
 from avocado.utils import archive
@@ -665,21 +666,16 @@ def postprocess_vm(test, params, env, name):
                     serial_login=serial_login,
                 )
 
-    # Close all SSH sessions that might be active to this VM
-    for s in vm.remote_sessions[:]:
-        try:
-            s.close()
-            vm.remote_sessions.remove(s)
-        except Exception:
-            pass
-
-    utils_logfile.close_log_file()
-
     if params.get("vm_extra_dump_paths") is not None:
+        # even if there is previously existing session we cannot guarantee its state
+        # is viable, e.g. it may be in python .env or SMTP sub-session, etc.
+        session = vm.wait_for_login(timeout=vm.LOGIN_WAIT_TIMEOUT)
         vm_extra_dumps = os.path.join(test.outputdir, "vm_extra_dumps")
         if not os.path.exists(vm_extra_dumps):
             os.makedirs(vm_extra_dumps)
-        for dump_path in params.get("vm_extra_dump_paths").split(";"):
+        for i, dump_path in enumerate(
+            params.get_list("vm_extra_dump_paths", delimiter=";")
+        ):
             try:
                 vm.copy_files_from(dump_path, vm_extra_dumps)
             except:
@@ -688,6 +684,35 @@ def postprocess_vm(test, params, env, name):
                     dump_path,
                     vm.name,
                 )
+            if params.get_boolean(f"verify_vm_extra_dump_{i}"):
+                for message in params.get_list(
+                    f"expected_vm_extra_dump_{i}", delimiter=";"
+                ):
+                    LOG.info(f"Checking for expected message in {dump_path}")
+                    if not ops.grep(
+                        session, message, dump_path, check=True, flags="-aP"
+                    ):
+                        raise exceptions.TestFail(
+                            f"Missing expected message '{message}' in {vm.name} extra dump {dump_path}"
+                        )
+                for message in params.get_list(
+                    f"unexpected_vm_extra_dump_{i}", delimiter=";"
+                ):
+                    LOG.info(f"Checking for unexpected message in {dump_path}")
+                    if ops.grep(session, message, dump_path, check=True, flags="-aP"):
+                        raise exceptions.TestFail(
+                            f"Redundant unexpected message '{message}' in {vm.name} extra dump {dump_path}"
+                        )
+
+    # Close all SSH sessions that might be active to this VM
+    for s in vm.remote_sessions[:]:
+        try:
+            s.close()
+            vm.remote_sessions.remove(s)
+        except Exception:
+            pass
+
+    utils_logfile.close_log_file()
 
     if params.get("kill_vm") == "yes":
         kill_vm_timeout = float(params.get("kill_vm_timeout", 0))