Skip to content

Calls stopPropagation even when no key combo applies #67

@leebyron

Description

@leebyron

I've noticed that because react-shortcuts overrides combokey's handleKey method, it doesn't check to see if a key combo in the key map actually applies before applying logic to preventDefault or stopPropagation. Since the stopPropagation prop defaults to true, this can result in other components on the page which react to keyboard events (like a select combo box) to stop receiving events, even though they don't interfere with the registered key combos.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions