Junit test: ITest.timestamp_input_is_tolerant_of_various_formats_in_all_locales

[JuKu]

I have debugged a little bit this JUnit test and i think the problem is the missing "a" in the SimpleDateFormat pattern, a stands for am/pm, see here:
https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html

Maybe this is also the problem in the others tests, the "a" was never considered.

[JuKu]

I have debugged a little bit more, the problem is in LanguageSetting.getLongTimeFormat(), there the "a" is missing.
But i dont know much about, what method getLongTimeFormat() do.

public DateFormat getLongTimeFormat() {
    return (SimpleDateFormat) DateFormat.getTimeInstance(DateFormat.MEDIUM);
}

Maybe here is the problem oft most of the failing JUnit tests?

Btw, if you print the exception (your catch-Block doesn't do anything yet, i have inserted a e.printStackTrace()), you get this exception:

java.text.ParseException: Unparseable date: "11:37 PM"
	at java.base/java.text.DateFormat.parse(DateFormat.java:395)
	at com.teamunify.i18n.I.stringToTime(I.java:695)
	at com.teamunify.i18n.I.stringToTimestamp(I.java:664)
	at com.teamunify.i18n.ITests.timestamp_input_is_tolerant_of_various_formats_in_all_locales(ITests.java:832)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

I have also added a test output to your for loop to find the wrong pattern:

fmt1: HH:mm:ss
fmt1: HH:mm
fmt1: H:m:s a
fmt1: H:m a
fmt1: H:m:s.S
fmt1: HHmm
Pattern from class: HH:mm:ss <-- this pattern is the not working one

So the first entry s.getLongTimeFormat() --> LanguageSetting.getLongTimeFormat() is the problem.

[JuKu]

For debugging i have changed the method a little bit, so that a Exception is thrown, if no pattern fit for the time string:

public static Date stringToTime(Date refDate, String timeString) {
    if (isNullDate(refDate)) {
      if (defaultDate == null)
        refDate = new Date();
      else
        refDate = defaultDate;
    }
    Date timeDate = new Date(0, 0, 0, 0, 0, 0);

    LanguageSetting s = languageProvider.vend();
    for (DateFormat fmt : new DateFormat[] { s.getLongTimeFormat(), s.getShortTimeFormat(),
                                             s.getMilitaryTimeFormat(true), s.getMilitaryTimeFormat(false),
                                             s.getAccurateTimeFormat(), s.getCompactMilitaryTimeFormat()}) {
      boolean found = false;

      try {
        timeDate = fmt.parse(timeString);
        found = true;
        break;
      } catch (ParseException e) {
      }

      if (!found) {
        for (DateFormat fmt1 : new DateFormat[] { s.getLongTimeFormat(), s.getShortTimeFormat(),
                s.getMilitaryTimeFormat(true), s.getMilitaryTimeFormat(false),
                s.getAccurateTimeFormat(), s.getCompactMilitaryTimeFormat() }) {
          System.err.println(((SimpleDateFormat) fmt1).toLocalizedPattern());
        }


        throw new IllegalStateException("No pattern found for time string: " + timeString);
      }
    }

    return new Date(refDate.getYear(), refDate.getMonth(), refDate.getDate(), timeDate.getHours(),
                    timeDate.getMinutes(), timeDate.getSeconds());
  }

The output on the test is:

HH:mm:ss
HH:mm
H:m:s
H:m
H:m:s.S
HHmm

java.lang.IllegalStateException: No pattern found for time string: 11:37 PM

	at com.teamunify.i18n.I.stringToTime(I.java:712)
	at com.teamunify.i18n.I.stringToTimestamp(I.java:664)
	at com.teamunify.i18n.ITests.timestamp_input_is_tolerant_of_various_formats_in_all_locales(ITests.java:832)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

So this means there is not pattern to handle am / pm times, yet.

[JuKu]

With a little quick&dirty fix, the junit test is passing:
JuKu@0809c06

The problem was, that SimpleDateFormat doesn't note the am / pm at the end of the string. But i don't know, why.

[awkay]

So, I appreciate the work, but I don't have time to maintain this, which is why the new maintainer issue is open. If you want to take over (on your fork), and deploy it via maven, then I'd be glad to redirect the README to your fork.