Skip to content

Commit 4791fb2

Browse files
Fix flaky test Count GroupBy (temporalio#9003)
## What changed? Verify when all CHASM visibility executions have completed, instead of exiting when at least one execution has completed. ## Why? Counting CHASM executions with GroupBy filtering fails during test verification due to a non-deterministic verification. The current code assumes all 5 executions have been written to visibility, if CountExecutions call returns ANY value greater than 0. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
1 parent dbc08f1 commit 4791fb2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tests/chasm_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ func (s *ChasmTestSuite) TestCountExecutions_GroupBy() {
405405
Query: "GROUP BY `PayloadExecutionStatus`",
406406
},
407407
)
408-
return err == nil && countResp != nil && countResp.Count > 0
408+
return err == nil && countResp != nil && countResp.Count >= 5
409409
},
410410
testcore.WaitForESToSettle,
411411
100*time.Millisecond,

0 commit comments

Comments
 (0)