feat: content type validation

Author: awlsring

proxmox/storage-class/common.go

@@ -4,10 +4,22 @@ import (
 	"context"
 
 	"github.com/awlsring/terraform-provider-proxmox/internal/service"
+	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
+	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
+	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 )
 
+func ContentTypeValidator(t ...string) []validator.List {
+	return []validator.List{
+		listvalidator.UniqueValues(),
+		listvalidator.ValueStringsAre(
+			stringvalidator.OneOf(t...),
+		),
+	}
+}
+
 func DetermineContentTypes(ctx context.Context, c types.List, defaults []string) ([]string, error) {
 	if c.IsNull() || c.IsUnknown() {
 		return defaults, nil

proxmox/storage-class/nfs/schema.go

@@ -1,6 +1,7 @@
 package nfs
 
 import (
+	"github.com/awlsring/terraform-provider-proxmox/proxmox/storage-class"
 	ds "github.com/hashicorp/terraform-plugin-framework/datasource/schema"
 	rs "github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/listplanmodifier"
@@ -81,6 +82,14 @@ var resourceSchema = rs.Schema{
 			PlanModifiers: []planmodifier.List{
 				listplanmodifier.UseStateForUnknown(),
 			},
+			Validators: storage.ContentTypeValidator(
+				"images",
+				"rootdir",
+				"vztmpl",
+				"backup",
+				"iso",
+				"snippets",
+			),
 		},
 		"mount": rs.StringAttribute{
 			Computed:    true,

proxmox/storage-class/zfs/resource.go

@@ -9,7 +9,6 @@ import (
 	"github.com/awlsring/terraform-provider-proxmox/proxmox/utils"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
-	"github.com/hashicorp/terraform-plugin-framework/types"
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 )
 
@@ -142,47 +141,6 @@ func (r *zfsResource) readstorageClassZfsModel(ctx context.Context, name string)
 	return ZFSStorageClassToModel(s), nil
 }
 
-func (r *zfsResource) determineNodes(ctx context.Context, n types.List) ([]string, error) {
-	if n.IsNull() || n.IsUnknown() {
-		tflog.Debug(ctx, "nodes is null or unknown")
-		nodes, err := r.client.ListNodesNames(ctx)
-		if err != nil {
-			return nil, err
-		}
-		return nodes, nil
-	}
-	tflog.Debug(ctx, "nodes is not null or unknown")
-	nodes := []string{}
-	for _, node := range n.Elements() {
-		v, err := node.ToTerraformValue(ctx)
-		if err != nil {
-			return nil, err
-		}
-		var n string
-		v.As(&n)
-		nodes = append(nodes, n)
-	}
-	return nodes, nil
-}
-
-func (r *zfsResource) determineContentTypes(ctx context.Context, c types.List) ([]string, error) {
-	if c.IsNull() || c.IsUnknown() {
-		return []string{"images", "rootdir"}, nil
-	}
-	tflog.Debug(ctx, "content types is not null or unknown")
-	contentTypes := []string{}
-	for _, contentType := range c.Elements() {
-		v, err := contentType.ToTerraformValue(ctx)
-		if err != nil {
-			return nil, err
-		}
-		var c string
-		v.As(&c)
-		contentTypes = append(contentTypes, c)
-	}
-	return contentTypes, nil
-}
-
 func (r *zfsResource) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
 	tflog.Debug(ctx, "Update bridge method")
 	var plan storageClassZfsModel

proxmox/storage-class/zfs/schema.go

@@ -1,6 +1,7 @@
 package zfs
 
 import (
+	"github.com/awlsring/terraform-provider-proxmox/proxmox/storage-class"
 	ds "github.com/hashicorp/terraform-plugin-framework/datasource/schema"
 	rs "github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/listplanmodifier"
@@ -84,6 +85,10 @@ var resourceSchema = rs.Schema{
 			PlanModifiers: []planmodifier.List{
 				listplanmodifier.UseStateForUnknown(),
 			},
+			Validators: storage.ContentTypeValidator(
+				"images",
+				"rootdir",
+			),
 		},
 	},
 }