fix: guard inquirer readline and disable conpty for node 24 (replaces patch-package)

Replaces the two patch-package patches with code-owned fixes so the
Node 24 behavior ships in compiled source rather than post-install
patches.

A new bootstrap shim (packages/amplify-cli/src/node24-inquirer-shim.ts)
overrides inquirer's base UI.close() to skip rl.pause() on an
already-closed readline, avoiding ERR_USE_AFTER_CLOSE on Node 24. It is
installed idempotently as the first statement of run() in index.ts, so
it ships to customers via the compiled cli-internal lib and runs before
any prompt can fire.

The e2e asciinema recorder now spawns node-pty with useConpty: false to
avoid the Windows ConPTY AttachConsole failure during PTY teardown on
Node 24, while keeping ...this.options last so callers can override.

The inquirer+7.3.3 and node-pty+1.1.0 patch files are removed since the
code fixes replace them. The patch-package devDependency and postinstall
hook are intentionally left in place as a harmless no-op (minimal
change; husky untouched).

---
Prompt: On the node24 branch (PR #14959), replace the two patch-package
patches with code-owned fixes: A1 (inquirer bootstrap shim in
amplify-cli source) + B (useConpty: false in the e2e harness), and
remove both .patch files. Then build/validate, commit, push.

Author: sarayev

packages/amplify-cli/src/index.ts

@@ -35,6 +35,7 @@ import { deleteOldVersion } from './utils/win-utils';
 import { notify } from './version-notifier';
 import { getAmplifyVersion } from './extensions/amplify-helpers/get-amplify-version';
 import { init as initErrorHandler, handleException, handleUnhandledRejection } from './amplify-exception-handler';
+import { installInquirerNode24Shim } from './node24-inquirer-shim';
 
 export { UsageData } from './domain/amplify-usageData';
 
@@ -64,6 +65,10 @@ const disableCDKDeprecationWarning = () => {
  * Command line entry point
  */
 export const run = async (startTime: number): Promise<void> => {
+  // Node 24: guard inquirer's readline teardown against ERR_USE_AFTER_CLOSE.
+  // Must run before any prompt can fire.
+  installInquirerNode24Shim();
+
   process.stderr.write(
     '\n' +
       chalk.yellow(

packages/amplify-cli/src/node24-inquirer-shim.ts

@@ -0,0 +1,63 @@
+/* eslint-disable @typescript-eslint/no-var-requires, global-require */
+import type { Interface as ReadlineInterface } from 'readline';
+
+const NODE24_PATCH_FLAG = '__node24Patched';
+
+interface PatchableUI {
+  rl?: (ReadlineInterface & { closed?: boolean; output?: { end?: () => void; unmute?: () => void } }) | undefined;
+  activePrompt?: { close?: () => void } | null;
+  onForceClose?: (() => void) | undefined;
+}
+
+type PatchableUIProto = {
+  close?: (this: PatchableUI) => void;
+  [NODE24_PATCH_FLAG]?: boolean;
+};
+
+/**
+ * Guards inquirer's base `UI.close()` so it never calls `rl.pause()` on an
+ * already-closed readline interface. On Node 24 that call throws
+ * `ERR_USE_AFTER_CLOSE`, which surfaces as a crash when a prompt is torn down;
+ * on Node <= 22 `pause()` was a silent no-op.
+ *
+ * The override is installed once (idempotent via a prototype flag) and replaces
+ * `baseUI`'s prototype `close`. When the readline is still open it delegates to
+ * the original implementation; otherwise it replicates the teardown best-effort
+ * without touching `pause()`. Safe to call multiple times and a no-op if the
+ * `inquirer/lib/ui/baseUI` module cannot be resolved.
+ */
+export const installInquirerNode24Shim = (): void => {
+  let baseUIModule: { default?: unknown } | (new (...args: unknown[]) => unknown);
+  try {
+    baseUIModule = require('inquirer/lib/ui/baseUI');
+  } catch {
+    return;
+  }
+
+  const UI = ((baseUIModule as { default?: unknown }).default ?? baseUIModule) as (new (...args: unknown[]) => unknown) | undefined;
+  const proto = UI?.prototype as PatchableUIProto | undefined;
+  if (!proto || typeof proto.close !== 'function' || proto[NODE24_PATCH_FLAG]) {
+    return;
+  }
+
+  const originalClose = proto.close;
+  proto.close = function patchedClose(this: PatchableUI): void {
+    const rl = this.rl;
+    if (rl && rl.closed !== true) {
+      originalClose.call(this);
+      return;
+    }
+
+    // Readline already closed: mirror baseUI teardown but skip rl.pause() to
+    // avoid ERR_USE_AFTER_CLOSE on Node 24.
+    if (rl && this.onForceClose) {
+      rl.removeListener?.('SIGINT', this.onForceClose);
+      process.removeListener('exit', this.onForceClose);
+    }
+    rl?.output?.unmute?.();
+    this.activePrompt?.close?.();
+    rl?.output?.end?.();
+    rl?.close?.();
+  };
+  proto[NODE24_PATCH_FLAG] = true;
+};

packages/amplify-e2e-core/src/asciinema-recorder.ts

@@ -61,6 +61,9 @@ export class Recorder {
       shell: true,
       // Do not set useConpty. node-pty is smart enough to set it to true only on versions of Windows that support it.
       // useConpty: true,
+      // Node 24 + Windows: force the winpty backend. ConPTY's AttachConsole path can throw during
+      // PTY teardown on Node 24, so we opt out of ConPTY here to keep e2e recordings stable.
+      useConpty: false,
       ...this.options,
     });
     this.addFrame(this.renderPrompt(this.cwd, this.cmd, this.args));