Skip to content

Commit c75d694

Browse files
fix: containers - don't wait for pipeline on hosting (#6137)
* fix: containers - don't wait for pipeline on hosting * fix: remove mkdir from Dockerfile (hosting template) * Update index.js * Update index.js
1 parent 6289f5d commit c75d694

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

  • packages

packages/amplify-category-api/src/provider-utils/awscloudformation/ecs-alb-stack.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class EcsAlbStack extends ContainersStack {
2121
constructor(scope: cdk.Construct, id: string, private readonly ecsProps: EcsStackProps) {
2222
super(scope, id, {
2323
...ecsProps,
24-
skipWait: false,
24+
skipWait: true,
2525
createCloudMapService: false,
2626
});
2727

packages/amplify-container-hosting/lib/ElasticContainer/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export async function generateHostingResources(
147147

148148
if (foundUnmetRequirements) {
149149
try {
150-
authName = await context.amplify.invokePluginMethod(context, 'auth', undefined, 'add', [
150+
authName = await context.amplify.invokePluginMethod(context, 'auth', undefined, 'externalAuthEnable', [
151151
context,
152152
'api',
153153
resourceName,
@@ -306,6 +306,7 @@ export async function generateHostingResources(
306306
if (addResource) {
307307
return context.amplify.updateamplifyMetaAfterResourceAdd(constants.CategoryName, serviceName, resource);
308308
} else {
309+
await context.amplify.updateamplifyMetaAfterResourceUpdate(constants.CategoryName, serviceName, 'restrictAccess', restrictAccess);
309310
await context.amplify.updateamplifyMetaAfterResourceUpdate(constants.CategoryName, serviceName, 'hostedZoneId', hostedZoneId);
310311
await context.amplify.updateamplifyMetaAfterResourceUpdate(constants.CategoryName, serviceName, 'exposedContainer', exposedContainer);
311312
await context.amplify.updateamplifyMetaAfterResourceUpdate(constants.CategoryName, serviceName, 'environmentMap', environmentMap);
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
FROM public.ecr.aws/bitnami/node:14.15.1-debian-10-r8
22

3-
RUN mkdir /app
43
WORKDIR /app
54

65
COPY package*.json ./
@@ -9,4 +8,4 @@ COPY . .
98

109
EXPOSE 8080
1110

12-
CMD ["node", "index.js"]
11+
CMD ["node", "index.js"]

0 commit comments

Comments
 (0)