Commit dd44915
committed
fix: guard node-pty conpty AttachConsole failure on node 24 (windows e2e)
Add a patch-package patch for node-pty@1.1.0 that wraps the
getConsoleProcessList(shellPid) call in conpty_console_list_agent.js
in a try/catch. Under Node v24 on Windows, the forked ConPTY console
list agent calls the native getConsoleProcessList, which invokes Win32
AttachConsole and can throw "AttachConsole failed" during PTY teardown.
The uncaught throw destabilizes the PTY so the nexpect harness can no
longer answer interactive prompts, causing e2e Windows shards (e.g.
geo_multi_env_searchable_datastore) to hang until the 1200s no-output
kill.
The guard falls back to [shellPid] on failure so the agent still sends
a valid console process list and exits 0, letting the parent kill()
proceed cleanly.
---
Prompt: Add a patch-package patch that fixes the Node 24 / Windows
ConPTY `AttachConsole failed` crash in node-pty, on the node24 branch,
and push it.1 parent 70a55d2 commit dd44915
1 file changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
0 commit comments