Fix linter

Author: Jonas Greifenhain

packages/amplify_lints/lib/app.yaml

@@ -1,8 +1,9 @@
 include: package:flutter_lints/flutter.yaml
 
+plugins:
+  amplify_lints: any
+
 analyzer:
-  plugins:
-    - custom_lint
   language:
     strict-casts: true
     strict-inference: true
@@ -16,7 +17,7 @@ linter:
     - avoid_field_initializers_in_const_classes        # To prefer using getters over fields.
     - cancel_subscriptions                             # To avoid memory leaks and to prevent code from firing after a subscription is no longer being used.
     - close_sinks                                      # To avoid memory leaks.
-    - directives_ordering                              # To maintain visual separation of a file’s imports.
+    - directives_ordering                              # To maintain visual separation of a file's imports.
     - eol_at_end_of_file                               # To provide consistency across our repos/languages.
     - flutter_style_todos                              # To ensure traceability of TODOs.
     - invalid_case_patterns                            # To prevent invalid case statements.

packages/amplify_lints/lib/library.yaml

@@ -1,8 +1,9 @@
 include: package:lints/recommended.yaml
 
+plugins:
+  amplify_lints: any
+
 analyzer:
-  plugins:
-    - custom_lint
   language:
     strict-casts: true
     strict-inference: true
@@ -33,7 +34,7 @@ linter:
     - conditional_uri_does_not_exist                   # To prevent accidentally referencing a nonexistent file.
     - depend_on_referenced_packages                    # To prevent issues publishing.
     - deprecated_consistency                           # To encourage correct usage of deprecation and provide a better DX.
-    - directives_ordering                              # To maintain visual separation of a file’s imports.
+    - directives_ordering                              # To maintain visual separation of a file's imports.
     - eol_at_end_of_file                               # To provide consistency across our repos/languages.
     - flutter_style_todos                              # To ensure traceability of TODOs.
     - invalid_case_patterns                            # To prevent invalid case statements.

packages/amplify_lints/lib/src/lints/missing_license_header.dart

@@ -1,8 +1,12 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import 'package:analyzer/error/listener.dart';
-import 'package:custom_lint_builder/custom_lint_builder.dart';
+import 'package:analyzer/analysis_rule/analysis_rule.dart';
+import 'package:analyzer/analysis_rule/rule_context.dart';
+import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/error/error.dart';
 
 /// The expected license header lines.
 const licenseHeader = [
@@ -25,32 +29,54 @@ const licenseHeader = [
 /// ```dart
 /// library my_library;
 /// ```
-class MissingLicenseHeader extends DartLintRule {
+class MissingLicenseHeader extends AnalysisRule {
   /// Creates a new [MissingLicenseHeader] lint rule.
-  MissingLicenseHeader() : super(code: _code);
+  MissingLicenseHeader()
+    : super(
+        name: 'missing_license_header',
+        description:
+            'Dart files must start with the Amazon copyright and '
+            'Apache-2.0 license header.',
+      );
 
-  static const _code = LintCode(
-    name: 'missing_license_header',
-    problemMessage:
-        'Dart files must start with the Amazon copyright and '
-        'Apache-2.0 license header.',
+  /// The lint code reported by this rule.
+  static const LintCode code = LintCode(
+    'missing_license_header',
+    'Dart files must start with the Amazon copyright and Apache-2.0 '
+        'license header.',
     correctionMessage: 'Add the license header to the top of this file.',
   );
 
   @override
-  void run(
-    CustomLintResolver resolver,
-    ErrorReporter reporter,
-    CustomLintContext context,
+  LintCode get diagnosticCode => code;
+
+  @override
+  void registerNodeProcessors(
+    RuleVisitorRegistry registry,
+    RuleContext context,
   ) {
-    context.registry.addCompilationUnit((node) {
-      final content = resolver.source.contents.data;
+    final visitor = _Visitor(this, context);
+    registry.addCompilationUnit(this, visitor);
+  }
+}
+
+class _Visitor extends SimpleAstVisitor<void> {
+  _Visitor(this.rule, this.context);
+
+  final AnalysisRule rule;
+  final RuleContext context;
+
+  @override
+  void visitCompilationUnit(CompilationUnit node) {
+    final unit = context.currentUnit;
+    if (unit == null) return;
 
-      if (_hasLicenseHeader(content)) return;
+    // Use the content provided by the analysis context (no need to read
+    // the file from disk).
+    if (_hasLicenseHeader(unit.content)) return;
 
-      // Report the lint on the first token in the file.
-      reporter.atToken(node.beginToken, _code);
-    });
+    // Report the lint on the first token in the file.
+    rule.reportAtToken(node.beginToken);
   }
 }
 

packages/amplify_lints/pubspec.yaml

@@ -9,12 +9,13 @@ environment:
   sdk: ^3.9.0
 
 dependencies:
+  analysis_server_plugin: any
   analyzer: any
   analyzer_plugin: any
-  custom_lint: any
-  custom_lint_builder: any
   flutter_lints: ^6.0.0
   lints: ^6.0.0
 
 dev_dependencies:
+  analyzer_testing: ^0.1.0
   test: ^1.24.0
+  test_reflective_loader: ^0.2.0