docs: correct stale versions, paths, links, and API signatures

Audited the markdown against the actual repo contents and fixed the claims
that contradict it. Each item below was verified against Package.swift, the
source, or by resolving the URL.

Version and tooling facts:
- CONTRIBUTING.md said Xcode 13.4 minimum; README.md and AGENTS.md say 16.0,
  and 13.4 cannot even parse `swift-tools-version:5.9`.
- CONTRIBUTING.md specified a 100-character line limit; SwiftLint enforces 160.
- CONTRIBUTING.md's Tools section listed only Xcode, omitting the SwiftFormat
  0.60.1 / SwiftLint 0.54.0 pins and Fastlane that CI actually requires.
- AGENTS.md said 19 test targets (there are 23) and "60+" workflows (70).

Wrong or dead references:
- AWS SDK for Swift linked to github.com/aws-amplify/aws-sdk-swift; the
  correct org is awslabs, per Package.swift.
- Six dead CONTRIBUTING.md TOC anchors (off-by-one step links, a
  "Running Cocoapods Locally" entry with no target section).
- Four legacy docs.amplify.aws /lib/...q/platform/ios URLs updated to the
  paths they now redirect to.
- bug_report.yaml pointed at the old amplify-ios repo and asked Swift users
  for an Amplify CLI log; LogsGuidance.md is about Xcode console output.
- ETHOS.md named a nonexistent AWSStoragePlugin (it is AWSS3StoragePlugin).
- AmplifyTests/CoreTests/README.md described an amplifyconfiguration.json
  sample that is not in that directory, and predated amplify_outputs.json.

Corrected code and structure claims:
- AmplifyClients/AGENTS.md: KinesisError.unknown has three associated values,
  not two; the initializer is `throws`; `record` is `@discardableResult`; the
  User-Agent example double-stamped the version, which UserAgentClientEngine
  already injects as lib/amplify-swift#<version>.
- AmplifyClients/AGENTS.md: added the missing AmplifyRecordCache layer (used
  by Kinesis and Firehose) and corrected the integration-test layout, which
  is not co-located per client.
- AmplifyPlugins/AGENTS.md: unit-test directory names vary by plugin, so the
  single stated pattern was wrong for most of them. Also removed
  `@visibleForTesting`, which is not a Swift attribute and has zero
  occurrences in this codebase.
- Amplify/AGENTS.md: named the two actual DefaultPlugins and resolved the
  contradiction about Hub needing no plugin.
- Documented that api-dump/ covers only four modules, and distinguished
  api-breaking-changes-detection.yml from api_digester_check.yml.
- Documented that SwiftLint's `included:` scope excludes AmplifyClients/,
  AmplifyFoundation/, and AmplifyFoundationBridge/, and that the lint
  workflows do not run on pull_request.
- Added the footnote the README's visionOS "Preview*" marker was missing, and
  noted visionOS is not declared in Package.swift but inherited from iOS.
- Surfaced the Amazon Pinpoint retirement notice (Oct 30, 2026) in README.md
  and AmplifyPlugins/AGENTS.md; previously only the migration guide carried
  it while the README still listed Analytics as GA with no caveat.
- Fixed a syntax error in both README-combine-support.md samples
  (`search(for "coffee")` was missing its colon) and two LogsGuidance.md typos.

Author: harsh62

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -87,8 +87,8 @@ body:
     attributes:
       label: Relevant log output
       description: >-
-        Include any relevant log output under
-        `~/.amplify/logs/amplify-cli-<issue-date>.log` (See: [Logs Guidance](https://github.com/aws-amplify/amplify-ios/blob/main/LogsGuidance.md))
+        Include any relevant log output from the Xcode console
+        (See: [Logs Guidance](https://github.com/aws-amplify/amplify-swift/blob/main/LogsGuidance.md))
       value: |
         <details>
         <summary>Log Messages</summary>

AGENTS.md

@@ -13,11 +13,13 @@ Detailed conventions and patterns live closer to the code. Read the relevant gui
 
 - [`Amplify/AGENTS.md`](Amplify/AGENTS.md) — Core framework: categories, plugin protocols, error handling, configuration, Hub
 - [`AmplifyPlugins/AGENTS.md`](AmplifyPlugins/AGENTS.md) — Plugin implementations: Auth, API, Storage, DataStore, etc.
-- [`AmplifyClients/AGENTS.md`](AmplifyClients/AGENTS.md) — Standalone clients: Foundation, Bridge, Kinesis (new pattern)
+- [`AmplifyClients/AGENTS.md`](AmplifyClients/AGENTS.md) — Standalone clients: Kinesis, Firehose, Connect, EventEnrichment, plus shared RecordCache (new pattern)
 
 ## Linting & Formatting (MUST pass)
 
-**Always run `swiftformat` on changed files before every commit.** CI enforces both formatting and linting — PRs will fail if files are not formatted. See `.swiftlint.yml` and `.swiftformat` for full rules.
+**Always run `swiftformat` on changed files before every commit.** The SwiftFormat and SwiftLint workflows run on pushes to non-default branches (not on `pull_request`), so format locally rather than relying on a PR check to catch it. See `.swiftlint.yml` and `.swiftformat` for full rules.
+
+Note that `.swiftlint.yml` only lints `Amplify/` and `AmplifyPlugins/` — `AmplifyClients/`, `AmplifyFoundation/`, and `AmplifyFoundationBridge/` are outside SwiftLint's `included:` scope, though SwiftFormat covers the whole repo.
 
 ```bash
 swiftformat <changed-files>   # Format changed files before committing
@@ -42,7 +44,7 @@ swiftlint --fix               # Then lint
 amplify-swift/
 ├── Amplify/                    # Core framework (categories, protocols, errors, config)
 ├── AmplifyPlugins/             # AWS service plugins (Auth, API, Storage, DataStore, etc.)
-├── AmplifyClients/             # Standalone AWS clients (Kinesis) — new pattern
+├── AmplifyClients/             # Standalone AWS clients (Kinesis, Firehose, Connect, EventEnrichment) — new pattern
 ├── AmplifyFoundation/          # Shared protocols (credentials, logging, errors) — no deps
 ├── AmplifyFoundationBridge/    # Foundation ↔ AWS SDK adapters
 ├── AmplifyTests/               # Core unit tests
@@ -84,7 +86,7 @@ chore: update aws-swift-sdk dependency
 ```
 
 **Types**: `feat`, `fix`, `chore`, `refactor`, `test`, `docs`, `perf`, `ci`
-**Scopes**: `auth`, `api`, `storage`, `datastore`, `geo`, `analytics`, `logging`, `predictions`, `push`, `kinesis`, `core`, `foundation`
+**Scopes**: `auth`, `api`, `storage`, `datastore`, `geo`, `analytics`, `logging`, `predictions`, `push`, `kinesis`, `firehose`, `connect`, `core`, `foundation`
 
 No period at end. One feature/bugfix per PR. Reference issues: `fixes #<issue>`.
 
@@ -95,7 +97,7 @@ swift test                                          # All unit tests
 swift test --filter AWSCognitoAuthPluginUnitTests    # Specific target
 ```
 
-- **Unit tests**: XCTest, defined in Package.swift (19 test targets)
+- **Unit tests**: XCTest, defined in Package.swift (23 test targets)
 - **Integration tests**: Xcode host app projects under `AmplifyPlugins/<Category>/Tests/<Category>HostApp/`
 - **Conventions**: Mock via behavior protocols, use `AmplifyTestCommon` for shared utilities, `AmplifyAsyncTesting` for async helpers
 - **Test documentation**: Use Given/When/Then doc comments on all test methods:
@@ -114,11 +116,11 @@ swift test --filter AWSCognitoAuthPluginUnitTests    # Specific target
 
 ## Semver
 
-New enum cases = **minor** bump. Breaking API changes = **major** (rare, needs approval). API surface tracked via `api-dump/` JSON snapshots and CI checks.
+New enum cases = **minor** bump. Breaking API changes = **major** (rare, needs approval). API surface tracked via `api-dump/` JSON snapshots and CI checks, currently covering four modules only: `Amplify`, `AWSPluginsCore`, `AWSDataStorePlugin`, and `CoreMLPredictionsPlugin`.
 
 ## CI/CD
 
-60+ GitHub Actions workflows in `.github/workflows/`: per-category unit tests (`unit_test_*.yml`), integration tests (`integ_test_*.yml`), platform builds, SwiftLint/SwiftFormat checks, API digester, CodeQL, Fortify. Releases via Fastlane.
+70 GitHub Actions workflows in `.github/workflows/`: per-category unit tests (`unit_test_*.yml`), integration tests (`integ_test_*.yml`), platform builds, SwiftLint/SwiftFormat checks, API digester, CodeQL, Fortify. Releases via Fastlane.
 
 ## Common Agent Tasks
 

Amplify/AGENTS.md

@@ -34,7 +34,7 @@ Amplify/
 │   ├── Auth/            # AuthCategoryBehavior (sign-in, sign-up, session, MFA)
 │   ├── DataStore/       # DataStoreCategoryBehavior (sync, query, observe)
 │   ├── Geo/             # GeoCategoryBehavior (search, maps)
-│   ├── Hub/             # Built-in pub/sub event system (no plugin needed)
+│   ├── Hub/             # Pub/sub event system (no user setup needed — backed by the built-in AWSHubPlugin)
 │   ├── Logging/         # LoggingCategoryBehavior
 │   ├── Notifications/   # Push notification behavior
 │   ├── Predictions/     # ML prediction behavior (text, vision, speech)
@@ -47,7 +47,7 @@ Amplify/
 │   ├── Model/           # Model, Schema, Field definitions (DataStore)
 │   ├── Plugin/          # Plugin protocol, PluginKey, Resettable
 │   └── Support/         # AmplifyError protocol, utilities
-├── DefaultPlugins/      # Built-in default plugin implementations
+├── DefaultPlugins/      # AWSHubPlugin and AWSUnifiedLoggingPlugin (registered automatically)
 └── DevMenu/             # Developer debug menu
 ```
 
@@ -107,7 +107,7 @@ let token = Amplify.Hub.listen(to: .auth) { payload in ... }
 
 ## API Surface Stability
 
-API dumps in `api-dump/*.json` track the public surface. Breaking changes detected by CI (`api_digester_check.yml`). New enum cases = minor bump; removing/renaming public APIs = major bump (needs approval).
+API dumps in `api-dump/*.json` track the public surface of four modules (`Amplify`, `AWSPluginsCore`, `AWSDataStorePlugin`, `CoreMLPredictionsPlugin`). Breaking changes detected by CI (`api-breaking-changes-detection.yml`; `api_digester_check.yml` separately verifies the digester tool itself against the `api-dump-test/` fixtures). New enum cases = minor bump; removing/renaming public APIs = major bump (needs approval).
 
 ## Adding a New API to a Category
 

AmplifyClients/AGENTS.md

@@ -9,7 +9,11 @@ Amplify Clients are **standalone AWS service clients** independent of the core `
 ```
 ┌─────────────────────────────────────────────────────────┐
 │  Amplify Clients  (e.g., AmplifyKinesisClient)          │
-│  High-level APIs, actor-based, local caching, retry     │
+│  High-level APIs, actor-based, retry                    │
+├─────────────────────────────────────────────────────────┤
+│  AmplifyRecordCache  (Shared Caching Layer)             │
+│  SQLite-backed record buffering, used by Kinesis and    │
+│  Firehose                                               │
 ├─────────────────────────────────────────────────────────┤
 │  AmplifyFoundation  (Protocol Layer)                    │
 │  Pure Swift protocols — zero external deps              │
@@ -60,8 +64,8 @@ Deps: `AmplifyFoundation`, `AmplifyFoundationBridge`, `SQLite.swift`, `AWSKinesi
 
 ```swift
 public class AmplifyKinesisClient {
-    init(region: String, credentialsProvider: AWSCredentialsProvider, options: Options)
-    func record(data: Data, partitionKey: String, streamName: String) async throws -> RecordData
+    init(region: String, credentialsProvider: any AmplifyFoundation.AWSCredentialsProvider, options: Options = Options()) throws
+    @discardableResult func record(data: Data, partitionKey: String, streamName: String) async throws -> RecordData
     func flush() async throws -> FlushData
     func enable() async / func disable() async
     func clearCache() async throws -> ClearCacheData
@@ -76,7 +80,7 @@ public enum KinesisError: AmplifyError {
     case cache(ErrorDescription, RecoverySuggestion, Error?)
     case cacheLimitExceeded(ErrorDescription, RecoverySuggestion, Error?)
     case validation(ErrorDescription, RecoverySuggestion, Error?)
-    case unknown(ErrorDescription, Error?)
+    case unknown(ErrorDescription, RecoverySuggestion, Error?)
 }
 ```
 
@@ -90,18 +94,22 @@ AmplifyClients/Amplify<Service>Client/
 │   ├── Amplify<Service>Client.swift      # Public facade
 │   └── Support/                           # Error type, actors, protocols, impls
 ├── Tests/
-│   ├── UnitTests/
-│   └── IntegrationTests/
+│   └── UnitTests/
 ```
 
+Integration tests are not co-located per client. `AmplifyConnectClient` has its own host app under `Tests/ConnectClientHostApp/`, Kinesis and Firehose share `AmplifyClients/Tests/IntegrationTests/KinesisFirehoseClientHostApp/`, and `AmplifyEventEnrichmentClient` has unit tests only.
+
 ### Package.swift target
 
 ```swift
 .target(
     name: "Amplify<Service>Client",
     dependencies: ["AmplifyFoundation", "AmplifyFoundationBridge",
+                    // Add "AmplifyRecordCache" (+ the SQLite product) only if the
+                    // client buffers records locally, as Kinesis and Firehose do.
                     .product(name: "AWS<Service>", package: "aws-sdk-swift")],
     path: "AmplifyClients/Amplify<Service>Client/Sources",
+    resources: [.copy("Resources/PrivacyInfo.xcprivacy")],
     swiftSettings: [.enableUpcomingFeature("StrictConcurrency")]
 )
 ```
@@ -130,6 +138,8 @@ var config = try AWS<Service>.<Service>Client.<Service>ClientConfiguration(
 )
 config.httpClientEngine = UserAgentClientEngine(
     target: config.httpClientEngine,
-    additionalMetadata: ["md/amplify-<service>#\(AmplifyMetadata.version)"]
+    additionalMetadata: ["md/amplify-<service>"]
 )
 ```
+
+Do not append the version here — `UserAgentClientEngine` already injects `lib/amplify-swift#<version>`, so adding `AmplifyMetadata.version` to the `md/` segment stamps it twice.

AmplifyPlugins/AGENTS.md

@@ -19,7 +19,9 @@
 | `Predictions/` | `AWSPredictionsPlugin` | Comprehend, Polly, Rekognition, Textract, Translate, Transcribe | Predictions |
 | `Predictions/` | `CoreMLPredictionsPlugin` | On-device CoreML | Predictions |
 | `Storage/` | `AWSS3StoragePlugin` | Amazon S3 | Storage |
-| `Core/` | `AWSPluginsCore`, `InternalAmplifyCredentials` | Shared plugin infra | Core |
+| `Core/` | `AWSPluginsCore`, `InternalAmplifyCredentials`, `AWSPluginsTestCommon` | Shared plugin infra (and shared test utilities) | Core |
+
+> **Amazon Pinpoint retirement** — Pinpoint is scheduled to be retired on October 30, 2026. This affects `AWSPinpointAnalyticsPlugin`, `AWSPinpointPushNotificationsPlugin`, and `InternalAWSPinpoint`.
 
 ## Plugin File Organization
 
@@ -46,7 +48,7 @@ Every plugin follows an extension-based pattern:
 - Constructor-based with optional parameters and defaults
 - Services injected during `configure(using:)` phase
 - Behavior protocols abstract AWS service calls (e.g., `AWSAuthCredentialsProviderBehavior`)
-- `@visibleForTesting` for test-only injection points
+- Test-only injection points are exposed via `internal` access plus `@testable import` — there is no `@visibleForTesting` attribute in Swift
 
 ## Logging
 
@@ -63,7 +65,7 @@ extension AWSAPIPlugin {
 
 ## Testing
 
-**Unit tests**: `AmplifyPlugins/<Category>/Tests/<PluginName>UnitTests/` (SPM test targets)
+**Unit tests**: SPM test targets under `AmplifyPlugins/<Category>/Tests/`. Naming varies — most are `<PluginName>Tests` (e.g. `AWSAPIPluginTests`, `AWSS3StoragePluginTests`), Auth/Analytics/Predictions/Push use a `UnitTests` suffix (e.g. `AWSCognitoAuthPluginUnitTests`), and DataStore is `AWSDataStoreCategoryPluginTests`. Core's live at `AmplifyPlugins/Core/AWSPluginsCoreTests` and `AmplifyPlugins/Core/AmplifyCredentialsTests`. Check `Package.swift` for the exact target name.
 
 **Integration tests**: `AmplifyPlugins/<Category>/Tests/<Category>HostApp/` (Xcode projects) — require AWS credentials and provisioned backends. Multiple test plan variants per category (Gen1, Gen2, auth modes, etc.).
 

AmplifyTests/CoreTests/README.md

@@ -1,6 +1,9 @@
 # Amplify Configuration Tests
 
-Amplify allows for configuration from either an in-memory `AmplifyConfiguration` object, or from an `amplifyconfiguration.json` file (which simply deserializes
-into an `AmplifyConfiguration` object.
+Amplify supports configuration from an in-memory `AmplifyConfiguration` object, from an
+`amplifyconfiguration.json` file (Gen1, which deserializes into an `AmplifyConfiguration`),
+or from an `amplify_outputs.json` file (Gen2, which deserializes into `AmplifyOutputsData`).
 
-As we add new categories, we will add new stanzas to the sample `amplifyconfiguration.json` file in this directory, to ensure compatibility.
+Test fixtures live alongside the tests rather than in this directory — see
+`AmplifyConfigurationInitializationTests.swift` and `AmplifyOutputsInitializationTests.swift`.
+As we add new categories, extend the fixtures in those tests to ensure compatibility.