-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathDiagnostics.test.ts
More file actions
220 lines (186 loc) · 8.19 KB
/
Diagnostics.test.ts
File metadata and controls
220 lines (186 loc) · 8.19 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
import { join } from 'path';
import { describe, it, expect, beforeAll, afterAll, beforeEach } from 'vitest';
import { TestExtension } from '../utils/TestExtension';
import { WaitFor } from '../utils/Utils';
describe('Diagnostic Features', () => {
const client = new TestExtension({
initializeParams: {
initializationOptions: {
aws: {
clientInfo: {
extension: {
name: 'Test CloudFormation Language Server',
version: '1.0.0-test',
},
clientId: 'test-client',
},
},
settings: {
diagnostics: {
cfnGuard: {
enabled: true,
rulesFile: join(__dirname, '../resources/guard/test-guard-rules.guard'),
delayMs: 100,
validateOnChange: true,
},
},
},
},
},
});
beforeAll(async () => {
await client.ready();
// Configure guard with custom rules file
await client.changeConfiguration({
settings: {
diagnostics: {
cfnGuard: {
enabled: true,
rulesFile: join(__dirname, '../resources/guard/test-guard-rules.guard'),
delayMs: 100,
validateOnChange: true,
},
},
},
});
});
beforeEach(async () => {
await client.reset();
});
afterAll(async () => {
await client.close();
});
describe('Guard diagnostics while authoring', () => {
it('should receive diagnostics during incremental typing', async () => {
// Start with basic template that should trigger our custom guard rules
const initialTemplate = `AWSTemplateFormatVersion: '2010-09-09'
Resources:
MyBucket:
Type: AWS::S3::Bucket`;
const uri = await client.openYamlTemplate(initialTemplate);
// Wait for diagnostics from our custom guard rules
await WaitFor.waitFor(() => {
if (client.receivedDiagnostics.length === 0) {
throw new Error('No diagnostics received yet');
}
}, 5000);
expect(client.receivedDiagnostics.length).toBeGreaterThan(0);
const latestDiagnostics = client.receivedDiagnostics[client.receivedDiagnostics.length - 1];
expect(latestDiagnostics.uri).toBe(uri);
expect(latestDiagnostics.diagnostics.length).toBeGreaterThan(0);
// Verify we got our custom guard diagnostics
const guardDiagnostics = latestDiagnostics.diagnostics.filter((d: any) => d.source === 'cfn-guard');
expect(guardDiagnostics.length).toBeGreaterThan(0);
await client.closeDocument({ textDocument: { uri } });
});
it('should receive diagnostics when typing new resource incrementally', async () => {
// Start with minimal template
const initialTemplate = `AWSTemplateFormatVersion: '2010-09-09'
Resources:`;
const uri = await client.openYamlTemplate(initialTemplate);
await new Promise((resolve) => setTimeout(resolve, 300));
// Type resource name
await client.changeDocument({
textDocument: { uri, version: 2 },
contentChanges: [
{
range: {
start: { line: 2, character: 10 },
end: { line: 2, character: 10 },
},
text: `
MyBucket:`,
},
],
});
await new Promise((resolve) => setTimeout(resolve, 200));
// Type resource type
await client.changeDocument({
textDocument: { uri, version: 3 },
contentChanges: [
{
range: {
start: { line: 3, character: 11 },
end: { line: 3, character: 11 },
},
text: `
Type: AWS::S3::Bucket`,
},
],
});
// Wait for guard diagnostics after adding a resource type
await WaitFor.waitFor(() => {
const diags = client.receivedDiagnostics;
const latest = diags[diags.length - 1];
if (latest?.uri !== uri || latest.diagnostics.length === 0) {
throw new Error('No diagnostics received yet for typed resource');
}
}, 5000);
const latest = client.receivedDiagnostics[client.receivedDiagnostics.length - 1];
expect(latest.uri).toBe(uri);
expect(latest.diagnostics.length).toBeGreaterThan(0);
const guardDiags = latest.diagnostics.filter((d: any) => d.source === 'cfn-guard');
expect(guardDiags.length).toBeGreaterThan(0);
await client.closeDocument({ textDocument: { uri } });
});
it('should receive diagnostics for public access violations', async () => {
// Create bucket with public access explicitly disabled
const template = `AWSTemplateFormatVersion: '2010-09-09'
Resources:
MyBucket:
Type: AWS::S3::Bucket
Properties:
BucketName: public-bucket
PublicAccessBlockConfiguration:
BlockPublicAcls: false
BlockPublicPolicy: false
IgnorePublicAcls: false
RestrictPublicBuckets: false`;
const uri = await client.openYamlTemplate(template);
// Wait for guard diagnostics about public access
await WaitFor.waitFor(() => {
const diags = client.receivedDiagnostics;
const latest = diags[diags.length - 1];
if (latest?.uri !== uri || latest.diagnostics.length === 0) {
throw new Error('No diagnostics received yet');
}
}, 5000);
const latest = client.receivedDiagnostics[client.receivedDiagnostics.length - 1];
expect(latest.uri).toBe(uri);
const guardDiags = latest.diagnostics.filter((d: any) => d.source === 'cfn-guard');
expect(guardDiags.length).toBeGreaterThan(0);
// Should flag the public access configuration
const publicAccessDiag = guardDiags.find((d: any) => /PublicAccessBlock|public/i.test(d.message));
expect(publicAccessDiag).toBeDefined();
await client.closeDocument({ textDocument: { uri } });
});
it('should clear diagnostics when document is closed', async () => {
const template = `AWSTemplateFormatVersion: '2010-09-09'
Resources:
MyBucket:
Type: AWS::S3::Bucket`;
const uri = await client.openYamlTemplate(template);
// Wait for diagnostics to arrive
await WaitFor.waitFor(() => {
const latest = client.receivedDiagnostics[client.receivedDiagnostics.length - 1];
if (latest?.uri !== uri || latest.diagnostics.length === 0) {
throw new Error('No diagnostics received yet');
}
}, 5000);
// Close the document
await client.closeDocument({ textDocument: { uri } });
// Wait for empty diagnostics to be published for the closed URI
await WaitFor.waitFor(() => {
const clearEvent = client.receivedDiagnostics.find(
(d: any) => d.uri === uri && d.diagnostics.length === 0,
);
if (!clearEvent) {
throw new Error('Diagnostics not cleared after close');
}
}, 5000);
const clearEvent = client.receivedDiagnostics.find((d: any) => d.uri === uri && d.diagnostics.length === 0);
expect(clearEvent).toBeDefined();
expect(clearEvent.diagnostics).toHaveLength(0);
});
});
});