Skip to content

Commit b3ee8aa

Browse files
authored
chore: remove aws-sdk-go (v1) dependency (#64)
Issue #, if available: aws-controllers-k8s/community#2783 Description of changes: Removes the transitive `github.com/aws/aws-sdk-go` (v1) dependency by bumping the referenced service controllers to releases whose `apis/v1alpha1` no longer force-import aws-sdk-go: - iam-controller -> v1.9.0 - kms-controller -> v1.5.0 After the bump, `go mod why -m github.com/aws/aws-sdk-go` reports "main module does not need module github.com/aws/aws-sdk-go" and the dependency is gone from the require block and go.sum, so it is no longer compiled into the controller binary. Generated code and ATTRIBUTION.md were regenerated to match. `go build ./...` and `go test ./...` pass. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 7524b2f commit b3ee8aa

7 files changed

Lines changed: 73 additions & 345 deletions

File tree

ATTRIBUTION.md

Lines changed: 0 additions & 267 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ License Identifier: Apache-2.0
3939

4040
Subdependencies:
4141
* `github.com/aws-controllers-k8s/runtime`
42-
* `github.com/aws/aws-sdk-go`
4342
* `github.com/aws/aws-sdk-go-v2`
4443
* `github.com/aws/aws-sdk-go-v2/service/iam`
4544
* `github.com/aws/smithy-go`
@@ -81,7 +80,6 @@ Subdependencies:
8180
* `github.com/itchyny/gojq`
8281
* `github.com/itchyny/timefmt-go`
8382
* `github.com/jaypipes/envutil`
84-
* `github.com/jmespath/go-jmespath`
8583
* `github.com/josharian/intern`
8684
* `github.com/json-iterator/go`
8785
* `github.com/mailru/easyjson`
@@ -126,10 +124,6 @@ Subdependencies:
126124

127125
License Identifier: Apache-2.0
128126

129-
#### github.com/aws/aws-sdk-go
130-
131-
License Identifier: Apache-2.0
132-
133127
#### github.com/aws/aws-sdk-go-v2
134128

135129
License Identifier: Apache-2.0
@@ -643,10 +637,6 @@ SOFTWARE.
643637

644638
License Identifier: Apache-2.0
645639

646-
#### github.com/jmespath/go-jmespath
647-
648-
License Identifier: Apache-2.0
649-
650640
#### github.com/josharian/intern
651641

652642
License Identifier: MIT
@@ -1557,7 +1547,6 @@ License Identifier: Apache-2.0
15571547

15581548
Subdependencies:
15591549
* `github.com/aws-controllers-k8s/runtime`
1560-
* `github.com/aws/aws-sdk-go`
15611550
* `github.com/aws/aws-sdk-go-v2`
15621551
* `github.com/aws/aws-sdk-go-v2/service/kms`
15631552
* `github.com/aws/smithy-go`
@@ -1641,268 +1630,12 @@ Subdependencies:
16411630

16421631

16431632

1644-
1645-
16461633
#### github.com/aws/aws-sdk-go-v2/service/kms
16471634

16481635
License Identifier: Apache-2.0
16491636

1650-
### github.com/aws-controllers-k8s/runtime
1651-
1652-
License Identifier: Apache-2.0
1653-
1654-
Subdependencies:
1655-
* `github.com/aws/aws-sdk-go-v2`
1656-
* `github.com/aws/aws-sdk-go-v2/config`
1657-
* `github.com/aws/aws-sdk-go-v2/credentials`
1658-
* `github.com/aws/aws-sdk-go-v2/service/sts`
1659-
* `github.com/aws/smithy-go`
1660-
* `github.com/cenkalti/backoff/v4`
1661-
* `github.com/go-logr/logr`
1662-
* `github.com/go-logr/zapr`
1663-
* `github.com/google/go-cmp`
1664-
* `github.com/itchyny/gojq`
1665-
* `github.com/jaypipes/envutil`
1666-
* `github.com/micahhausler/aws-iam-policy`
1667-
* `github.com/pkg/errors`
1668-
* `github.com/prometheus/client_golang`
1669-
* `github.com/spf13/pflag`
1670-
* `github.com/stretchr/testify`
1671-
* `go.uber.org/zap`
1672-
* `k8s.io/api`
1673-
* `k8s.io/apimachinery`
1674-
* `k8s.io/client-go`
1675-
* `k8s.io/klog/v2`
1676-
* `k8s.io/utils`
1677-
* `sigs.k8s.io/controller-runtime`
1678-
* `sigs.k8s.io/yaml`
1679-
* `github.com/aws/aws-sdk-go-v2/feature/ec2/imds`
1680-
* `github.com/aws/aws-sdk-go-v2/internal/configsources`
1681-
* `github.com/aws/aws-sdk-go-v2/internal/endpoints/v2`
1682-
* `github.com/aws/aws-sdk-go-v2/internal/ini`
1683-
* `github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding`
1684-
* `github.com/aws/aws-sdk-go-v2/service/internal/presigned-url`
1685-
* `github.com/aws/aws-sdk-go-v2/service/sso`
1686-
* `github.com/aws/aws-sdk-go-v2/service/ssooidc`
1687-
* `github.com/beorn7/perks`
1688-
* `github.com/cespare/xxhash/v2`
1689-
* `github.com/davecgh/go-spew`
1690-
* `github.com/emicklei/go-restful/v3`
1691-
* `github.com/evanphx/json-patch`
1692-
* `github.com/evanphx/json-patch/v5`
1693-
* `github.com/fsnotify/fsnotify`
1694-
* `github.com/fxamacker/cbor/v2`
1695-
* `github.com/go-openapi/jsonpointer`
1696-
* `github.com/go-openapi/jsonreference`
1697-
* `github.com/go-openapi/swag`
1698-
* `github.com/google/btree`
1699-
* `github.com/google/gnostic-models`
1700-
* `github.com/google/uuid`
1701-
* `github.com/itchyny/timefmt-go`
1702-
* `github.com/josharian/intern`
1703-
* `github.com/json-iterator/go`
1704-
* `github.com/mailru/easyjson`
1705-
* `github.com/modern-go/concurrent`
1706-
* `github.com/modern-go/reflect2`
1707-
* `github.com/munnerz/goautoneg`
1708-
* `github.com/pmezard/go-difflib`
1709-
* `github.com/prometheus/client_model`
1710-
* `github.com/prometheus/common`
1711-
* `github.com/prometheus/procfs`
1712-
* `github.com/stretchr/objx`
1713-
* `github.com/x448/float16`
1714-
* `go.uber.org/multierr`
1715-
* `go.yaml.in/yaml/v2`
1716-
* `go.yaml.in/yaml/v3`
1717-
* `golang.org/x/net`
1718-
* `golang.org/x/oauth2`
1719-
* `golang.org/x/sync`
1720-
* `golang.org/x/sys`
1721-
* `golang.org/x/term`
1722-
* `golang.org/x/text`
1723-
* `golang.org/x/time`
1724-
* `gomodules.xyz/jsonpatch/v2`
1725-
* `google.golang.org/protobuf`
1726-
* `gopkg.in/evanphx/json-patch.v4`
1727-
* `gopkg.in/inf.v0`
1728-
* `gopkg.in/yaml.v3`
1729-
* `k8s.io/apiextensions-apiserver`
1730-
* `k8s.io/kube-openapi`
1731-
* `sigs.k8s.io/json`
1732-
* `sigs.k8s.io/randfill`
1733-
* `sigs.k8s.io/structured-merge-diff/v6`
1734-
1735-
#### github.com/aws/aws-sdk-go-v2
1736-
1737-
License Identifier: Apache-2.0
1738-
1739-
1740-
1741-
1742-
1743-
1744-
1745-
1746-
1747-
1748-
1749-
1750-
1751-
1752-
1753-
1754-
1755-
1756-
1757-
1758-
1759-
1760-
1761-
1762-
1763-
1764-
1765-
1766-
1767-
1768-
1769-
1770-
1771-
17721637

17731638

1774-
1775-
1776-
1777-
1778-
1779-
1780-
1781-
1782-
1783-
1784-
1785-
1786-
1787-
1788-
1789-
1790-
1791-
1792-
1793-
1794-
1795-
1796-
1797-
1798-
1799-
1800-
1801-
1802-
1803-
1804-
1805-
1806-
1807-
1808-
1809-
#### github.com/evanphx/json-patch
1810-
1811-
License Identifier: BSD-3-Clause
1812-
1813-
Copyright (c) 2014, Evan Phoenix
1814-
All rights reserved.
1815-
1816-
Redistribution and use in source and binary forms, with or without
1817-
modification, are permitted provided that the following conditions are met:
1818-
1819-
* Redistributions of source code must retain the above copyright notice, this
1820-
list of conditions and the following disclaimer.
1821-
* Redistributions in binary form must reproduce the above copyright notice,
1822-
this list of conditions and the following disclaimer in the documentation
1823-
and/or other materials provided with the distribution.
1824-
* Neither the name of the Evan Phoenix nor the names of its contributors
1825-
may be used to endorse or promote products derived from this software
1826-
without specific prior written permission.
1827-
1828-
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
1829-
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
1830-
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
1831-
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
1832-
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
1833-
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
1834-
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
1835-
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
1836-
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
1837-
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
1838-
1839-
1840-
1841-
1842-
1843-
1844-
1845-
1846-
1847-
1848-
1849-
1850-
1851-
1852-
1853-
1854-
1855-
1856-
1857-
1858-
1859-
1860-
1861-
1862-
1863-
1864-
1865-
1866-
1867-
1868-
1869-
1870-
1871-
1872-
1873-
1874-
1875-
1876-
1877-
1878-
1879-
#### github.com/stretchr/objx
1880-
1881-
License Identifier: MIT
1882-
1883-
The MIT License
1884-
1885-
Copyright (c) 2014 Stretchr, Inc.
1886-
Copyright (c) 2017-2018 objx contributors
1887-
1888-
Permission is hereby granted, free of charge, to any person obtaining a copy
1889-
of this software and associated documentation files (the "Software"), to deal
1890-
in the Software without restriction, including without limitation the rights
1891-
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
1892-
copies of the Software, and to permit persons to whom the Software is
1893-
furnished to do so, subject to the following conditions:
1894-
1895-
The above copyright notice and this permission notice shall be included in all
1896-
copies or substantial portions of the Software.
1897-
1898-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
1899-
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
1900-
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
1901-
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
1902-
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
1903-
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
1904-
SOFTWARE.
1905-
19061639
### github.com/aws/aws-sdk-go-v2
19071640

19081641
License Identifier: Apache-2.0

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2026-08-28T18:57:58Z"
3-
build_hash: 399b047701458765c3dd8e9dd663ce2ef0337c05
4-
go_version: go1.26.5
5-
version: v0.63.0
2+
build_date: "2026-09-14T17:43:25Z"
3+
build_hash: 3da9ce283716fa8d0046dc18eeb1a79a9e6fb1a0
4+
go_version: go1.27.1
5+
version: v0.63.0-8-g3da9ce2
66
api_directory_checksum: 4d30a0fbacdfdc8488e3a5f389ec3bc6feacf610
77
api_version: v1alpha1
88
aws_service_sdk_version: v1.51.0

0 commit comments

Comments
 (0)