VPC Endpoint Service use requeue error instead of Synced false (#305)

knottnt · web-flow · commit 43d5cd4fb9ae · 2026-01-05T22:06:31.000Z
Issue #, if available:

Description of changes:
- use requeue error to avoid unnecessary delay in resource sync

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,5 +1,5 @@
 ack_generate_info:
-  build_date: "2025-12-30T23:03:05Z"
+  build_date: "2025-12-31T20:29:42Z"
   build_hash: ca61a7295e7f1b6adb9ee1f05dab9e99f5ff58e3
   go_version: go1.25.5
   version: v0.56.0-5-gca61a72
diff --git a/pkg/resource/vpc_endpoint_service_configuration/sdk.go b/pkg/resource/vpc_endpoint_service_configuration/sdk.go
diff --git a/templates/hooks/vpc_endpoint_service_configuration/sdk_create_post_set_output.go.tpl b/templates/hooks/vpc_endpoint_service_configuration/sdk_create_post_set_output.go.tpl
@@ -1,3 +1,3 @@
 
     // This causes a requeue and the rest of the fields will be synced on the next reconciliation loop
-	ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil)
+    return &resource{ko}, ackrequeue.Needed(errors.New("reconcile update only fields."))

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`
`2`	`2`	`// This causes a requeue and the rest of the fields will be synced on the next reconciliation loop`
`3`		`- ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil)`
	`3`	`+ return &resource{ko}, ackrequeue.Needed(errors.New("reconcile update only fields."))`