Move ggipc_connect_by_name to private header

Author: archigup

include/ggl/ipc/client.h

@@ -6,7 +6,6 @@
 #define GGL_IPC_CLIENT_H
 
 #include <ggl/arena.h>
-#include <ggl/attr.h>
 #include <ggl/buffer.h>
 #include <ggl/error.h>
 #include <ggl/ipc/error.h>
@@ -18,13 +17,6 @@ struct timespec;
 
 #define GGL_IPC_SVCUID_STR_LEN (16)
 
-/// Connect to GG-IPC server using component name.
-/// If svcuid is non-null, it will be filled with the component's identity
-/// token. Buffer must be able to hold at least GGL_IPC_SVCUID_STR_LEN.
-GglError ggipc_connect_by_name(
-    GglBuffer socket_path, GglBuffer component_name, int *fd, GglBuffer *svcuid
-) NONNULL(3);
-
 GglError ggipc_call(
     int conn,
     GglBuffer operation,

priv_include/ggl/ipc/client_priv.h

@@ -8,13 +8,12 @@
 #include <ggl/attr.h>
 #include <ggl/buffer.h>
 #include <ggl/error.h>
-#include <ggl/object.h>
 
-/// Connect to GG-IPC server with the given payload.
+/// Connect to GG-IPC server using component name.
 /// If svcuid is non-null, it will be filled with the component's identity
 /// token. Buffer must be able to hold at least GGL_IPC_SVCUID_STR_LEN.
-GglError ggipc_connect_with_payload(
-    GglBuffer socket_path, GglMap payload, int *fd, GglBuffer *svcuid
+GglError ggipc_connect_by_name(
+    GglBuffer socket_path, GglBuffer component_name, int *fd, GglBuffer *svcuid
 ) NONNULL(3);
 
 GglError ggipc_private_get_system_config(

src/ipc/client.c

@@ -45,6 +45,10 @@ static GglError send_message(
     GglMap *payload
 ) NONNULL_IF_NONZERO(2, 5);
 
+static GglError ggipc_connect_with_payload(
+    GglBuffer socket_path, GglMap payload, int *fd, GglBuffer *svcuid
+) NONNULL(3);
+
 static GglError send_message(
     int conn,
     const EventStreamHeader *headers,
@@ -122,16 +126,28 @@ static GglError get_message(
     return GGL_ERR_OK;
 }
 
-GglError ggipc_connect_with_payload(
+static GglError ggipc_connect_with_payload(
     GglBuffer socket_path, GglMap payload, int *fd, GglBuffer *svcuid
 ) {
     int conn = -1;
     GglError ret = ggl_connect(socket_path, &conn);
     if (ret != GGL_ERR_OK) {
+        GGL_LOGE(
+            "Failed to connect to GG-IPC socket at %.*s.",
+            (int) socket_path.len,
+            socket_path.data
+        );
         return ret;
     }
     GGL_CLEANUP_ID(conn_cleanup, cleanup_close, conn);
 
+    GGL_LOGI(
+        "Connected to GG-IPC socket at %.*s on fd %d",
+        (int) socket_path.len,
+        socket_path.data,
+        conn
+    );
+
     EventStreamHeader headers[] = {
         { GGL_STR(":message-type"),
           { EVENTSTREAM_INT32, .int32 = EVENTSTREAM_CONNECT } },