fix: we skip download if the same version of nucleus is being deployed (#1717)

* fix: we skip download if the same version of nucleus is being deployed

During installation the gg nucleus zip is not copied into the artifacts dir,
as the installer is contained in the zip file. Even if the zip file is copied,
it does not match the expected checksum, as there is some code signature added
in the zip file provided by the zip file coming from cloudfront.

This is now using the version that is provided by the localCandidate.getVersion()
function to determine if a download is necessary.
So the nucleus component is treated special.

Signed-off-by: Thomas Roos <[email protected]>

* chore: improve logging

---------

Signed-off-by: Thomas Roos <[email protected]>
Co-authored-by: Siddhant Srivastava <[email protected]>

Author: thomas-roos

src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java

@@ -39,6 +39,7 @@
 import com.aws.greengrass.util.NucleusPaths;
 import com.aws.greengrass.util.Permissions;
 import com.aws.greengrass.util.RetryUtils;
+import com.aws.greengrass.util.Utils;
 import com.vdurmont.semver4j.Requirement;
 import com.vdurmont.semver4j.Semver;
 import com.vdurmont.semver4j.SemverException;
@@ -203,8 +204,19 @@ private ComponentIdentifier negotiateVersionWithCloud(String componentName,
             Map<String, Requirement> versionRequirements,
             ComponentIdentifier localCandidate)
             throws PackagingException, InterruptedException {
-        ResolvedComponentVersion resolvedComponentVersion;
 
+        // Special handling for Nucleus component - skip download if same version
+        if (DEFAULT_NUCLEUS_COMPONENT_NAME.equals(componentName) && localCandidate != null) {
+            String currentNucleusVersion = deviceConfiguration.getNucleusVersion();
+            if (localCandidate.getVersion().toString().equals(currentNucleusVersion)) {
+                logger.atInfo().kv(COMPONENT_NAME, componentName)
+                        .kv("version", currentNucleusVersion)
+                        .log("Skipping Nucleus download as the same version is already installed");
+                return localCandidate;
+            }
+        }
+
+        ResolvedComponentVersion resolvedComponentVersion;
         if (localCandidate == null) {
             try {
                 resolvedComponentVersion = RetryUtils.runWithRetry(clientExceptionRetryConfig,
@@ -441,9 +453,14 @@ private void preparePackage(ComponentIdentifier componentIdentifier)
     void prepareArtifacts(ComponentIdentifier componentIdentifier, List<ComponentArtifact> artifacts)
             throws PackageLoadingException, PackageDownloadException, InvalidArtifactUriException,
             InterruptedException {
-        if (artifacts == null) {
-            logger.atWarn().kv(PACKAGE_IDENTIFIER, componentIdentifier)
-                    .log("Artifact list was null, expected non-null and non-empty");
+        if (Utils.isEmpty(artifacts)) {
+            if (DEFAULT_NUCLEUS_COMPONENT_NAME.equals(componentIdentifier.getName())) {
+                logger.atDebug().kv(PACKAGE_IDENTIFIER, componentIdentifier).log("Skipping Nucleus artifact"
+                        + " download as version to be deployed is already running");
+            } else {
+                logger.atWarn().kv(PACKAGE_IDENTIFIER, componentIdentifier)
+                        .log("Artifact list was null, expected non-null and non-empty");
+            }
             return;
         }
         Path packageArtifactDirectory = componentStore.resolveArtifactDirectoryPath(componentIdentifier);

src/test/java/com/aws/greengrass/componentmanager/ComponentManagerTest.java

@@ -182,8 +182,6 @@ void after() throws Exception {
     void GIVEN_artifact_list_empty_WHEN_attempt_download_artifact_THEN_do_nothing() throws Exception {
         ComponentIdentifier pkgId = new ComponentIdentifier("CoolService", new Semver("1.0.0"));
 
-        when(componentStore.resolveArtifactDirectoryPath(pkgId)).thenReturn(tempDir);
-
         componentManager.prepareArtifacts(pkgId, Collections.emptyList());
 
         verify(artifactDownloader, never()).download();
@@ -221,8 +219,6 @@ void GIVEN_artifact_from_gg_repo_WHEN_download_artifact_with_unarchive_THEN_call
     @Test
     void GIVEN_package_identifier_WHEN_request_to_prepare_package_THEN_task_succeed() throws Exception {
         ComponentIdentifier pkgId = new ComponentIdentifier("MonitoringService", new Semver("1.0.0"));
-        when(componentStore.resolveArtifactDirectoryPath(pkgId)).thenReturn(tempDir);
-
         String fileName = "MonitoringService-1.0.0.yaml";
         Path sourceRecipe = RECIPE_RESOURCE_PATH.resolve(fileName);