complete a couple more unit tests for file handling

Author: rpcme

.gitignore

@@ -5,3 +5,4 @@ packaged.yaml
 /.idea/
 .coverage
 **/__pycache__
+htmlcov

src/provider_espressif/main.py

@@ -37,7 +37,6 @@ def s3_object_stream(bucket_name: str, object_name: str):
 # Given a bucket name and object name, return bytes representing
 # the object content.
 def s3_filebuf_bytes(bucket_name: str, object_name: str):
-    file_stream = io.BytesIO()
     object_stream = s3_object_stream(bucket_name=bucket_name,
                                      object_name=object_name)
     return object_stream.getvalue()
@@ -62,7 +61,7 @@ def invoke_export(bucket_name: str, object_name: str, queueUrl: str):
         certificate_data['thing'] = thing_name
         sqs_client.send_message( QueueUrl=queueUrl,
                              MessageBody=json.dumps(certificate_data) )
-        
+
 def lambda_handler(event, context):
     queueUrl = os.environ['QUEUE_TARGET']
     bucket_name = event['Records'][0]['s3']['bucket']['name']

src/provider_espressif/testable.py

@@ -14,7 +14,7 @@ class LambdaSQSClass:
     """
     def __init__(self, lambda_sqs_resource):  
         """
-        Initialize an S3 Resource
+        Initialize an SQS Resource
         """
         self.resource = lambda_sqs_resource["resource"]
         self.queue_name = lambda_sqs_resource["queue_name"]

test/unit/src/test_provider_espressif.py

@@ -22,11 +22,13 @@ class TestProviderEspressif(TestCase):
 
     def setUp(self):
         self.test_s3_bucket_name = "unit_test_s3_bucket"
+        self.test_s3_object_content = None
         os.environ["S3_BUCKET_NAME"] = self.test_s3_bucket_name
         s3_client = client('s3', region_name="us-east-1")
         s3_client.create_bucket(Bucket = self.test_s3_bucket_name )
         with open('./test/artifacts/manifest-espressif.csv', 'rb') as data:
             s3_client.put_object(Bucket=self.test_s3_bucket_name, Key="manifest.csv", Body=data)
+            self.test_s3_object_content = s3_client.get_object(Bucket=self.test_s3_bucket_name, Key="manifest.csv")['Body']
         mocked_s3_resource = resource("s3")
         mocked_s3_resource = { "resource" : resource('s3'),
                                "bucket_name" : self.test_s3_bucket_name }
@@ -50,12 +52,20 @@ def test_neg_s3_object_resource(self):
         assert str(e.value) == "An error occurred (NoSuchBucket) when calling the HeadObject operation: The specified bucket does not exist"
 
     def test_pos_s3_filebuf_bytes(self):
-        s3_filebuf_bytes("unit_test_s3_bucket", "manifest.csv")
+        # The bytes should equal to the object in the bucket
+        v = s3_filebuf_bytes("unit_test_s3_bucket", "manifest.csv")
+        assert v == self.test_s3_object_content.read()
 
     def test_pos_invoke_export(self):
         invoke_export("unit_test_s3_bucket", "manifest.csv", "provider")
-        # The number of items in the queue should be 1
-        
+        # The number of items in the queue should be 7 since there are
+        # seven certificates in the test file
+        sqs_client = client("sqs", "us-east-1")
+        sqs_queue_url_r = sqs_client.get_queue_url(QueueName=self.test_sqs_queue_name)
+        sqs_queue_url = sqs_queue_url_r['QueueUrl']
+        p = sqs_client.get_queue_attributes(QueueUrl=sqs_queue_url, AttributeNames=['ApproximateNumberOfMessages'])
+        assert p['Attributes']['ApproximateNumberOfMessages'] == '7'
+
     def tearDown(self):
         s3_resource = resource("s3",region_name="us-east-1")
         s3_bucket = s3_resource.Bucket( self.test_s3_bucket_name )