Change positive value for FrameMatchSize to be 1

Changes:
* Update readme
* Flip the poitive value for FrameMatchSize
* Change the unit for FrameMatchSize to be Count

Author: lherman-cs

webrtc-c/canary/README.md

@@ -57,7 +57,7 @@ the granular access to these metrics.
 | Initialization     | SignalingInitDelay             | Miliseconds     | -          | -                   | Measure the time it takes for Signaling from creation to connected.                                                                                                              |
 | Initialization     | ICEHolePunchingDelay           | Miliseconds     | -          | -                   | Measure the time it takes for ICE agent to successfully connect to the other peer.                                                                                               |
 | End to End         | EndToEndFrameLatency           | Milliseconds    | -          | 30                  | The delay from sending the frame to when the frame is received on the other end                                                                                                  |
-| End to End         | FrameSizeMatch                 | None            | -          | 30                  | The decoded canary data (header + frame data) at the receiver end is compared with the received size as part of header). If equal, 0.0 is pushed as a metric, else 1.0 is pushed |
+| End to End         | FrameSizeMatch                 | None            | -          | 30                  | The decoded canary data (header + frame data) at the receiver end is compared with the received size as part of header). If equal, 1.0 is pushed as a metric, else 0.0 is pushed |
 | Outbound RTP Stats | FramesPerSecond                | Count_Second    | -          | 60                  | Measures the rate at which frames are sent out from the master. This is calculated using outboundRtpStats                                                                        |
 | Outbound RTP Stats | PercentageFrameDiscarded       | Percent         | -          | 60                  | This expresses the percentage of frames that dropped on the sending path within a given time interval. This is calculated using outboundRtpStats                                 |
 | Outbound RTP Stats | PercentageFramesRetransmitted  | Percent         | -          | 60                  | This expresses the percentage of frames that are retransmitted on the sending path within a given time interval.  This is calculated using outboundRtpStats                      |

webrtc-c/canary/src/CloudwatchMonitoring.cpp

@@ -245,7 +245,7 @@ VOID CloudwatchMonitoring::pushEndToEndMetrics(Canary::PEndToEndMetricsContext p
     this->push(endToEndLatencyDatum);
 
     sizeMatchDatum.SetMetricName("FrameSizeMatch");
-    sizeMatchDatum.SetUnit(StandardUnit::None);
+    sizeMatchDatum.SetUnit(StandardUnit::Count);
     auto& sizeMatches = pEndToEndMetricsContext->sizeMatch;
     auto averageSizeMatch = std::accumulate(sizeMatches.begin(), sizeMatches.end(), 0.0) / sizeMatches.size();
     sizeMatchDatum.SetValue(averageSizeMatch);

webrtc-c/canary/src/Peer.cpp

@@ -530,7 +530,7 @@ STATUS Peer::addTransceiver(RtcMediaStreamTrack& track)
 
         // Do a size match of the raw packet. Since raw packet does not contain the NALu, the
         // comparison would be rawPacketSize + ANNEX_B_NALU_SIZE and the received size
-        pPeer->endToEndMetricsContext.sizeMatch.push_back((rawPacketSize + ANNEX_B_NALU_SIZE) == receivedSize ? 0.0 : 1.0);
+        pPeer->endToEndMetricsContext.sizeMatch.push_back((rawPacketSize + ANNEX_B_NALU_SIZE) == receivedSize ? 1.0 : 0.0);
         SAFE_MEMFREE(rawPacket);
     };