Skip to content

Commit ac03e77

Browse files
spring-boot: Remove duplicate maven build (#324)
This PR removes the `pom.xml` and associated Maven commands from the Spring Boot code sample, since we already have the Gradle build in the same directory. The Maven build is not monitored by Dependabot, so will slowly drift out of sync with the Gradle definition. Removing the Maven build to match what is done for the other Java sample, which only provides Gradle. Rather than worrying about keeping both in sync, it's easier for us to just provide 1 build system. By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.
1 parent 70cbe9d commit ac03e77

3 files changed

Lines changed: 2 additions & 97 deletions

File tree

.github/workflows/java-spring-boot-integ-tests.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -16,40 +16,6 @@ on:
1616
workflow_dispatch:
1717

1818
jobs:
19-
test-maven:
20-
runs-on: ubuntu-latest
21-
permissions:
22-
id-token: write # required by aws-actions/configure-aws-credentials
23-
concurrency:
24-
group: ${{ github.workflow }}
25-
26-
steps:
27-
- name: Checkout code
28-
uses: actions/checkout@v6
29-
30-
- name: Set up JDK 17
31-
uses: actions/setup-java@v5
32-
with:
33-
java-version: "17"
34-
distribution: "corretto"
35-
architecture: x64
36-
cache: maven
37-
38-
- name: Configure AWS Credentials
39-
uses: aws-actions/configure-aws-credentials@v5
40-
with:
41-
role-to-assume: ${{ secrets.JAVA_IAM_ROLE }}
42-
aws-region: us-east-1
43-
44-
- name: Run Maven integration test
45-
working-directory: ./java/spring_boot
46-
env:
47-
CLUSTER_USER: admin
48-
CLUSTER_ENDPOINT: ${{ secrets.JAVA_SPRING_BOOT_CLUSTER_ENDPOINT }}
49-
REGION: ${{ secrets.JAVA_SPRING_BOOT_CLUSTER_REGION }}
50-
EXIT_AFTER_TEST: true
51-
run: mvn spring-boot:run
52-
5319
test-gradle:
5420
runs-on: ubuntu-latest
5521
permissions:

java/spring_boot/README.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,8 @@ connections should be used where possible to ensure data security during transmi
5757
java -version
5858
```
5959

60-
* Build Tool (Maven or Gradle)
61-
- _Maven_: Ensure Maven is installed if that is your preferred option. You can download it from
62-
the [official website](https://maven.apache.org/download.cgi).
63-
- _Gradle_: A Gradle wrapper is included with the example. If you prefer to use a system installation of Gradle, you
64-
can download it from the [official website](https://gradle.org/install/).
60+
* _Gradle_: A Gradle wrapper is included with the example. If you prefer to use a system installation of Gradle, you
61+
can download it from the [official website](https://gradle.org/install/).
6562
* AWS SDK: Ensure that you set up the latest version of the AWS Java
6663
SDK from the [official website](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/setup.html).
6764
* You must have an Aurora DSQL cluster. For information about creating an Aurora DSQL cluster, see the
@@ -103,14 +100,6 @@ The example is designed to work with both admin and non-admin users:
103100

104101
**Note:** running the example will use actual resources in your AWS account and may incur charges.
105102

106-
**Using Maven:**
107-
108-
```bash
109-
mvn spring-boot:run
110-
```
111-
112-
**Using Gradle:**
113-
114103
```bash
115104
./gradlew bootRun
116105
```

java/spring_boot/pom.xml

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)