Skip to content

Commit 7b2c0d6

Browse files
authored
Merge pull request #90 from controlshift/aws-cli-version-check-fix
fix check_cli_version failure when installed aws-cli is a higher major version
2 parents 8cb5e5d + d7e8813 commit 7b2c0d6

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

load-balancing/elb-v2/common_functions.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -685,14 +685,22 @@ check_cli_version() {
685685
msg "Checking minimum required CLI version (${min_version}) against installed version ($version)"
686686

687687
if [ $x -lt $min_x ]; then
688+
# major version is less than required. fail.
688689
return 1
690+
elif [ $x -gt $min_x ]; then
691+
# major version is greater than required. succeed.
692+
return 0
689693
elif [ $y -lt $min_y ]; then
694+
# minor version is less than required. fail.
690695
return 1
691696
elif [ $y -gt $min_y ]; then
697+
# minor version is greater than required. succeed.
692698
return 0
693699
elif [ $z -ge $min_z ]; then
700+
# patch version is at least the required version. succeed.
694701
return 0
695702
else
703+
# patch version is insufficient. fail.
696704
return 1
697705
fi
698706
}

0 commit comments

Comments
 (0)