Skip to content

Commit e15e180

Browse files
authored
fix: remove sensitive information from logs (#9)
- Remove secret name from Cognito credential retrieval logs - Remove URL from HTTP request logs to avoid exposing query parameters Fixes CodeQL alerts #1, #4, #18
1 parent f73cda5 commit e15e180

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/agentcore-agents/hotel-booking-agent/common/cognito_token_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def _get_cognito_credentials(self) -> dict[str, str]:
3434
"""
3535
try:
3636
if self._cached_credentials is None:
37-
logger.info(f"Retrieving Cognito credentials from secret: {self.secret_name}")
37+
logger.info("Retrieving Cognito credentials from Secrets Manager")
3838

3939
secret_value = self.secrets_client.get_secret_value(SecretId=self.secret_name)
4040
self._cached_credentials = json.loads(secret_value["SecretString"])

packages/agentcore-mcp-servers/hotel-booking/common/cognito_token_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def _get_cognito_credentials(self) -> dict[str, str]:
3434
"""
3535
try:
3636
if self._cached_credentials is None:
37-
logger.info(f"Retrieving Cognito credentials from secret: {self.secret_name}")
37+
logger.info("Retrieving Cognito credentials from Secrets Manager")
3838

3939
secret_value = self.secrets_client.get_secret_value(SecretId=self.secret_name)
4040
self._cached_credentials = json.loads(secret_value["SecretString"])

packages/agentcore-mcp-servers/hotel-booking/common/hotel_booking_support.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def _make_api_request(
6969
APIError: If the request fails
7070
"""
7171
try:
72-
logger.info(f"Making {method} request to {url}")
72+
logger.info(f"Making {method} request")
7373

7474
# Prepare the request body
7575
body = None

0 commit comments

Comments
 (0)