Skip to content

Commit 3577e48

Browse files
committed
Revert "Add observer prop to the BG Blur and Replacement Provider"
This reverts commit 5734acc.
1 parent 5734acc commit 3577e48

File tree

3 files changed

+5
-39
lines changed

3 files changed

+5
-39
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
### Added
1313

1414
- Refactor `toggleContentShare` function to allow specifying a `MediaStream` to share. This can be used to share non-screen share content.
15-
- Add the observer as a prop of Background Blur and Background Replacement Providers, so that builders can provide observers to the provider.
1615

1716
### Removed
1817

src/providers/BackgroundBlurProvider/index.tsx

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import {
55
BackgroundBlurOptions,
66
BackgroundBlurProcessor,
77
BackgroundBlurVideoFrameProcessor,
8-
BackgroundBlurVideoFrameProcessorObserver,
98
BackgroundFilterSpec,
109
ConsoleLogger,
1110
DefaultVideoTransformDevice,
1211
Device,
1312
LogLevel,
1413
NoOpVideoFrameProcessor,
14+
VideoFrameProcessor,
1515
} from 'amazon-chime-sdk-js';
1616
import React, {
1717
createContext,
@@ -33,10 +33,6 @@ interface Props extends BaseSdkProps {
3333
/** A set of options that can be supplied when creating a background blur video frame processor. For more information, refer to
3434
* [Amazon Chime SDK for JavaScript Background Filter Guide](https://github.com/aws/amazon-chime-sdk-js/blob/main/guides/15_Background_Filter_Video_Processor.md#adding-a-background-filter-to-your-application). */
3535
options?: BackgroundBlurOptions;
36-
/**
37-
* Observer callback functions. The observer will be added to the background blur processor on mount and removed on unmount.
38-
*/
39-
observer?: BackgroundBlurVideoFrameProcessorObserver;
4036
}
4137

4238
interface BackgroundBlurProviderState {
@@ -50,12 +46,12 @@ const BackgroundBlurProviderContext = createContext<
5046
BackgroundBlurProviderState | undefined
5147
>(undefined);
5248

53-
const BackgroundBlurProvider: FC<Props> = ({ spec, options, observer, children }) => {
49+
const BackgroundBlurProvider: FC<Props> = ({ spec, options, children }) => {
5450
const logger = useLogger();
5551
const [isBackgroundBlurSupported, setIsBackgroundBlurSupported] = useState<
5652
boolean | undefined
5753
>(undefined);
58-
const [processor, setProcessor] = useState<BackgroundBlurProcessor | undefined>();
54+
const [processor, setProcessor] = useState<VideoFrameProcessor | undefined>();
5955

6056
const blurSpec = useMemoCompare(
6157
spec,
@@ -101,18 +97,6 @@ const BackgroundBlurProvider: FC<Props> = ({ spec, options, observer, children }
10197
};
10298
}, [blurOptions, blurSpec]);
10399

104-
useEffect(() => {
105-
if (!!processor && !!observer) {
106-
processor.addObserver(observer);
107-
}
108-
109-
return () => {
110-
if (!!processor && !!observer) {
111-
processor.removeObserver(observer);
112-
}
113-
};
114-
}, [observer, processor]);
115-
116100
async function initializeBackgroundBlur(): Promise<
117101
BackgroundBlurProcessor | undefined
118102
> {

src/providers/BackgroundReplacementProvider/index.tsx

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import {
66
BackgroundReplacementOptions,
77
BackgroundReplacementProcessor,
88
BackgroundReplacementVideoFrameProcessor,
9-
BackgroundReplacementVideoFrameProcessorObserver,
109
ConsoleLogger,
1110
DefaultVideoTransformDevice,
1211
Device,
1312
LogLevel,
1413
NoOpVideoFrameProcessor,
14+
VideoFrameProcessor,
1515
} from 'amazon-chime-sdk-js';
1616
import React, {
1717
createContext,
@@ -33,10 +33,6 @@ interface Props extends BaseSdkProps {
3333
/* A set of options that can be supplied when creating a background replacement video frame processor such as the background replacement image blob. For more information, refer to
3434
* [Amazon Chime SDK for JavaScript Background Filter Guide](https://github.com/aws/amazon-chime-sdk-js/blob/main/guides/15_Background_Filter_Video_Processor.md#adding-a-background-filter-to-your-application). */
3535
options?: BackgroundReplacementOptions;
36-
/**
37-
* Observer callback functions. The observer will be added to the background replacement processor on mount and removed on unmount.
38-
*/
39-
observer?: BackgroundReplacementVideoFrameProcessorObserver;
4036
}
4137

4238
interface BackgroundReplacementProviderState {
@@ -53,15 +49,14 @@ const BackgroundReplacementProviderContext = createContext<
5349
const BackgroundReplacementProvider: FC<Props> = ({
5450
spec,
5551
options,
56-
observer,
5752
children,
5853
}) => {
5954
const logger = useLogger();
6055
const [
6156
isBackgroundReplacementSupported,
6257
setIsBackgroundReplacementSupported,
6358
] = useState<boolean | undefined>(undefined);
64-
const [processor, setProcessor] = useState<BackgroundReplacementProcessor | undefined>(
59+
const [processor, setProcessor] = useState<VideoFrameProcessor | undefined>(
6560
undefined
6661
);
6762

@@ -109,18 +104,6 @@ const BackgroundReplacementProvider: FC<Props> = ({
109104
};
110105
}, [replacementSpec, replacementOptions]);
111106

112-
useEffect(() => {
113-
if (!!processor && !!observer) {
114-
processor.addObserver(observer);
115-
}
116-
117-
return () => {
118-
if (!!processor && !!observer) {
119-
processor.removeObserver(observer);
120-
}
121-
};
122-
}, [observer, processor]);
123-
124107
async function initializeBackgroundReplacement(): Promise<
125108
BackgroundReplacementProcessor | undefined
126109
> {

0 commit comments

Comments
 (0)