Skip to content

Commit e90e1d7

Browse files
authored
Change console log to logger (#1001)
1 parent 5c32deb commit e90e1d7

File tree

2 files changed

+23
-25
lines changed

2 files changed

+23
-25
lines changed

src/providers/ContentShareProvider/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import React, {
1414

1515
import { ContentShareControlContextType } from '../../types';
1616
import { useAudioVideo } from '../AudioVideoProvider';
17+
import { useLogger } from '../LoggerProvider';
1718
import {
1819
ContentActionType,
1920
ContentShareState,
@@ -41,6 +42,7 @@ export const ContentShareProvider: React.FC<
4142
}>
4243
> = ({ children, maxContentShares = 1 }) => {
4344
const audioVideo = useAudioVideo();
45+
const logger = useLogger();
4446
const [state, dispatch] = useReducer(reducer, initialState);
4547
const {
4648
paused,
@@ -61,13 +63,13 @@ export const ContentShareProvider: React.FC<
6163

6264
useEffect(() => {
6365
if (maxContentShares > MAX_SUPPORTED_CONTENT_SHARES) {
64-
console.warn(
66+
logger.warn(
6567
`ContentShareProvider: maxContentShares value ${maxContentShares} exceeds the currently` +
6668
` supported maximum of ${MAX_SUPPORTED_CONTENT_SHARES}.` +
6769
`The value has been set to ${validatedMaxContentShares} instead.`
6870
);
6971
} else if (maxContentShares < MIN_SUPPORTED_CONTENT_SHARES) {
70-
console.warn(
72+
logger.warn(
7173
`ContentShareProvider: maxContentShares value ${maxContentShares} is below the minimum` +
7274
` of ${MIN_SUPPORTED_CONTENT_SHARES}. The value has been set to ${validatedMaxContentShares} instead.`
7375
);

src/providers/MeetingProvider/MeetingManager.ts

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ export class MeetingManager implements AudioVideoObserver {
219219
await this.meetingSession?.deviceController.chooseAudioOutput(null);
220220
await this.meetingSession?.deviceController.destroy();
221221
} catch (error) {
222-
console.log(
222+
this.logger.info(
223223
'MeetingManager failed to clean up media resources on leave'
224224
);
225225
}
@@ -238,7 +238,7 @@ export class MeetingManager implements AudioVideoObserver {
238238
}
239239

240240
audioVideoDidStart = (): void => {
241-
console.log(
241+
this.logger.info(
242242
'[MeetingManager audioVideoDidStart] Meeting started successfully'
243243
);
244244
this.meetingStatus = MeetingStatus.Succeeded;
@@ -259,37 +259,37 @@ export class MeetingManager implements AudioVideoObserver {
259259
const sessionStatusCode = sessionStatus.statusCode();
260260
switch (sessionStatusCode) {
261261
case MeetingSessionStatusCode.MeetingEnded:
262-
console.log(
262+
this.logger.info(
263263
`[MeetingManager audioVideoDidStop] Meeting ended for all: ${sessionStatusCode}`
264264
);
265265
this.meetingStatus = MeetingStatus.Ended;
266266
break;
267267
case MeetingSessionStatusCode.Left:
268-
console.log(
268+
this.logger.info(
269269
`[MeetingManager audioVideoDidStop] Left the meeting: ${sessionStatusCode}`
270270
);
271271
this.meetingStatus = MeetingStatus.Left;
272272
break;
273273
case MeetingSessionStatusCode.AudioJoinedFromAnotherDevice:
274-
console.log(
274+
this.logger.info(
275275
`[MeetingManager audioVideoDidStop] Meeting joined from another device: ${sessionStatusCode}`
276276
);
277277
this.meetingStatus = MeetingStatus.JoinedFromAnotherDevice;
278278
break;
279279
default:
280280
// The following status codes are Failures according to MeetingSessionStatus
281281
if (sessionStatus.isFailure() && !sessionStatus.isTerminal()) {
282-
console.log(
282+
this.logger.info(
283283
`[MeetingManager audioVideoDidStop] Non-Terminal failure occurred: ${sessionStatusCode}`
284284
);
285285
this.meetingStatus = MeetingStatus.Failed;
286286
} else if (sessionStatus.isTerminal()) {
287-
console.log(
287+
this.logger.info(
288288
`[MeetingManager audioVideoDidStop] Terminal failure occurred: ${sessionStatusCode}`
289289
);
290290
this.meetingStatus = MeetingStatus.TerminalFailure;
291291
} else {
292-
console.log(
292+
this.logger.info(
293293
`[MeetingManager audioVideoDidStop] session stopped with code ${sessionStatusCode}`
294294
);
295295
}
@@ -372,7 +372,7 @@ export class MeetingManager implements AudioVideoObserver {
372372
this.publishDeviceLabelTriggerStatus();
373373
return stream;
374374
} catch (error) {
375-
console.error('MeetingManager failed to get device permissions');
375+
this.logger.error('MeetingManager failed to get device permissions');
376376
this.deviceLabelTriggerStatus = DeviceLabelTriggerStatus.DENIED;
377377
this.publishDeviceLabelTriggerStatus();
378378
throw error;
@@ -440,9 +440,8 @@ export class MeetingManager implements AudioVideoObserver {
440440
this.audioInputDevices[0].deviceId
441441
);
442442
} catch (error) {
443-
console.error(
444-
'MeetingManager failed to select audio input device on join',
445-
error
443+
this.logger.error(
444+
`MeetingManager failed to select audio input device on join: ${error}`
446445
);
447446
}
448447
this.publishSelectedAudioInputDevice();
@@ -460,9 +459,8 @@ export class MeetingManager implements AudioVideoObserver {
460459
this.audioOutputDevices[0].deviceId
461460
);
462461
} catch (error) {
463-
console.error(
464-
'MeetingManager failed to select audio output device on join',
465-
error
462+
this.logger.error(
463+
`MeetingManager failed to select audio output device on join: ${error}`
466464
);
467465
}
468466
}
@@ -492,7 +490,7 @@ export class MeetingManager implements AudioVideoObserver {
492490
newError.name = error.name;
493491
newError.message += ' ' + error.message;
494492
}
495-
console.error(newError);
493+
this.logger.error(newError.toString());
496494
throw newError;
497495
}
498496
};
@@ -503,9 +501,8 @@ export class MeetingManager implements AudioVideoObserver {
503501
this.selectedAudioOutputDevice = deviceId;
504502
this.publishSelectedAudioOutputDevice();
505503
} catch (error) {
506-
console.error(
507-
'MeetingManager failed to select audio output device',
508-
error
504+
this.logger.error(
505+
`MeetingManager failed to select audio output device: ${error}`
509506
);
510507
throw new Error('MeetingManager failed to select audio output device');
511508
}
@@ -524,7 +521,7 @@ export class MeetingManager implements AudioVideoObserver {
524521
newError.name = error.name;
525522
newError.message += ' ' + error.message;
526523
}
527-
console.error(newError);
524+
this.logger.error(newError.toString());
528525
throw newError;
529526
}
530527
};
@@ -535,9 +532,8 @@ export class MeetingManager implements AudioVideoObserver {
535532
this.selectedVideoInputDevice = undefined;
536533
this.publishSelectedVideoInputDevice();
537534
} catch (error) {
538-
console.error(
539-
'MeetingManager failed to unselect video input device',
540-
error
535+
this.logger.error(
536+
`MeetingManager failed to unselect video input device: ${error}`
541537
);
542538
throw new Error('MeetingManager failed to unselect video input device');
543539
}

0 commit comments

Comments
 (0)