Revert "Version bump for [email protected] (#980) #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuesichao
reviewed
Jan 27, 2025
| } | ||
| process.chdir(path.join(__dirname, '../../dependency-check-app')); | ||
| spawnOrFail('npm', ['init -y']); | ||
| spawnOrFail('npm', ['install react@18 react-dom@18']); |
Contributor
There was a problem hiding this comment.
how is this related to version bump
Contributor
Author
There was a problem hiding this comment.
This was added during preflight. The release script failed due to incompatible React version. Now the latest React version is 19, but we only set 17, and 18 as peerDependency.
xuesichao
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2eb6e5d.
Issue #: Cancel the version bump.
Description of changes:
Testing
Have you successfully run
npm run build:releaselocally?How did you test these changes?
If you made changes to the component library, have you provided corresponding documentation changes?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.