Skip to content

Commit 36eacb4

Browse files
committed
Fix tests from reporting false positive
1 parent 782b85f commit 36eacb4

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

integration/mocha-tests/configs/WebDriverBaseConfig.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,13 @@ const config = {
2424
[
2525
'--use-fake-device-for-media-stream',
2626
'--use-fake-ui-for-media-stream',
27-
'--headless',
27+
'--headless=new',
28+
'--window-size=1920,1080',
2829
'--disable-gpu',
2930
'--no-sandbox',
3031
'--disable-dev-shm-usage'
3132
] :
32-
['--use-fake-device-for-media-stream', '--use-fake-ui-for-media-stream'],
33+
['--use-fake-device-for-media-stream', '--use-fake-ui-for-media-stream', '--window-size=1920,1080'],
3334
},
3435
},
3536
safariOptions: {
@@ -46,7 +47,7 @@ const config = {
4647
accessKey: process.env.SAUCE_ACCESS_KEY,
4748
noSSLBumpDomains: 'all',
4849
extendedDebugging: true,
49-
screenResolution: '1920x1200',
50+
screenResolution: '1920x1440',
5051
},
5152
},
5253
};

integration/mocha-tests/script/run-test.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ const startTesting = async (testSuite, testType) => {
278278
clients = integrationTestBrowserConfig;
279279
}
280280

281-
await runTest(test, clients);
281+
return await runTest(test, clients);
282282
};
283283

284284
/**
@@ -408,16 +408,20 @@ const terminateTestDemo = async () => {
408408

409409
startTestDemo();
410410

411+
let testResult = 0;
411412
try {
412413
await waitUntilTestDemoStarts();
413-
await startTesting(testSuite, testType);
414+
testResult = await startTesting(testSuite, testType);
414415
} finally {
415416
try {
416417
await terminateTestDemo();
417418
} catch (cleanupError) {
418419
logger.log(`Error during cleanup: ${cleanupError.message || cleanupError}`, LogLevel.ERROR);
419420
}
420421
}
422+
423+
// Exit with the test result code
424+
process.exit(testResult);
421425
} catch (error) {
422426
logger.log(`Test execution failed: ${error.message || error}`, LogLevel.ERROR);
423427
process.exit(1);

integration/mocha-tests/tests/TestSetup.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ function setupTestEnvironment(testName, Page) {
4545
this.logger
4646
);
4747
await driverFactoryOne.build();
48-
await driverFactoryOne.driver.manage().window().maximize();
4948
this.driverFactoryOne = driverFactoryOne;
5049
this.baseTestConfigOne = baseTestConfigOne;
5150

@@ -65,7 +64,6 @@ function setupTestEnvironment(testName, Page) {
6564
this.logger
6665
);
6766
await driverFactoryTwo.build();
68-
await driverFactoryTwo.driver.manage().window().maximize();
6967
this.driverFactoryTwo = driverFactoryTwo;
7068
this.baseTestConfigTwo = baseTestConfigTwo;
7169

0 commit comments

Comments
 (0)