Give the AKS Kubernetes resources a real dependency on the namespace

The cluster role binding, ECR pull secret, DaemonSet and load-generator Job all
named the namespace with the local string, which gives terraform no dependency
edge. All four were therefore launched in the same parallel batch as
kubernetes_namespace.cwagent instead of after it, and whichever lost the race
against the namespace create failed with "namespaces not found".

Run 30580467483 lost it on the secret: the namespace took 437ms to create while
the secret started 3ms behind it. The preceding run took 150ms for the same call
and the secret landed just after the namespace existed, which is why this had
passed until now. The service account was already immune because it referenced
the namespace resource rather than the string.

All four now reference kubernetes_namespace.cwagent.metadata[0].name, matching
the service account, so terraform orders them after the namespace.

Author: movence

terraform/azure/aks/main.tf

@@ -163,7 +163,7 @@ resource "kubernetes_cluster_role_binding" "cwagent" {
   subject {
     kind      = "ServiceAccount"
     name      = kubernetes_service_account.cwagent.metadata[0].name
-    namespace = local.namespace
+    namespace = kubernetes_namespace.cwagent.metadata[0].name
   }
 }
 
@@ -183,7 +183,7 @@ data "aws_ecr_authorization_token" "ecr" {
 resource "kubernetes_secret" "ecr_pull" {
   metadata {
     name      = "ecr-pull-secret"
-    namespace = local.namespace
+    namespace = kubernetes_namespace.cwagent.metadata[0].name
   }
   type = "kubernetes.io/dockerconfigjson"
   data = {
@@ -200,7 +200,7 @@ resource "kubernetes_secret" "ecr_pull" {
 resource "kubernetes_daemon_set_v1" "cwagent" {
   metadata {
     name      = "cloudwatch-agent"
-    namespace = local.namespace
+    namespace = kubernetes_namespace.cwagent.metadata[0].name
   }
 
   spec {
@@ -321,7 +321,7 @@ resource "kubernetes_daemon_set_v1" "cwagent" {
 resource "kubernetes_job_v1" "otlp_load" {
   metadata {
     name      = "otlp-load-generator"
-    namespace = local.namespace
+    namespace = kubernetes_namespace.cwagent.metadata[0].name
   }
 
   spec {