Skip to content

Commit bbb354a

Browse files
fix(otel): Make cloud.account.id assertion unconditional
cloud.account.id is always present on Karpenter metrics. Replace conditional check with require.True assertion to fail explicitly if the attribute is ever missing.
1 parent b218510 commit bbb354a

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

test/otel/solutions/karpenter/karpenter_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,8 @@ func TestKarpenterCloudAccountID(t *testing.T) {
306306
require.NotEmpty(t, results, "%s not available", metricName)
307307
for _, r := range results {
308308
acctID, ok := r.Labels.Resource["cloud.account.id"]
309-
if ok {
310-
require.Equal(t, cfg.AccountID, acctID, "%s cloud.account.id", metricName)
311-
}
309+
require.True(t, ok, "%s missing @resource.cloud.account.id", metricName)
310+
require.Equal(t, cfg.AccountID, acctID, "%s cloud.account.id", metricName)
312311
}
313312
})
314313
}

0 commit comments

Comments
 (0)