fix reload server method (#1957)

pete911 · web-flow · commit f347e7f9c983 · 2026-04-15T16:29:21.000-04:00
diff --git a/extension/server/extension.go b/extension/server/extension.go
@@ -107,7 +107,10 @@ func (s *Server) reloadServer(config *tls.Config) error {
 	// close the current server
 	if s.httpsServer != nil {
 		// closing the server gracefully
-		if err := s.httpsServer.Close(); err != nil {
+		ctx, cancel := context.WithTimeout(s.ctx, 10*time.Second)
+		defer cancel()
+		// Use Shutdown instead of Close: Shutdown closes the listener before returning,
+		if err := s.httpsServer.Shutdown(ctx); err != nil {
 			s.logger.Error("Failed to shutdown HTTPS server", zap.Error(err))
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,10 @@ func (s Server) reloadServer(config tls.Config) error {`
`107`	`107`	`// close the current server`
`108`	`108`	`if s.httpsServer != nil {`
`109`	`109`	`// closing the server gracefully`
`110`		`- if err := s.httpsServer.Close(); err != nil {`
	`110`	`+ ctx, cancel := context.WithTimeout(s.ctx, 10*time.Second)`
	`111`	`+ defer cancel()`
	`112`	`+ // Use Shutdown instead of Close: Shutdown closes the listener before returning,`
	`113`	`+ if err := s.httpsServer.Shutdown(ctx); err != nil {`
`111`	`114`	`s.logger.Error("Failed to shutdown HTTPS server", zap.Error(err))`
`112`	`115`	`}`
`113`	`116`	`}`