Add workload detection for PostgreSQL - #2220
Merged
Merged
Conversation
Paamicky
added
the
ready for testing
Paamicky
marked this pull request as ready for review
July 30, 2026 17:45
JayPolanco
approved these changes
Jul 30, 2026
musa-asad
reviewed
Jul 30, 2026
| return nil, err | ||
| } | ||
|
|
||
| if len(args) > 0 && strings.HasPrefix(strings.TrimSpace(args[0]), exeName+":") { |
Contributor
There was a problem hiding this comment.
nit: if cmdline is unreadable here (race with process exit, permission denied), this propagates the raw error even though we already confirmed the exe is postgres at L47. Could return ErrIncompatibleDetector instead so a transient /proc read failure doesn't surface as a detection error for a process we can't confirm is the main server. Low risk since the discoverer just continues past non-nil errors anyway.
musa-asad
approved these changes
Jul 30, 2026
Contributor
Binary Size Reportlinux/amd64
Notable changes:
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Adds workload detection support for PostgreSQL database servers as part of the workload-discovery feature
Description of changes
Implements a PostgreSQL process detector that:
:pattern in cmdline5432if neither is set. This is consistent with the upstreamOTEL PostgreSQL receiverdefaultNew files:
nternal/detector/postgresql/postgresql.go- Main detector implementationinternal/detector/postgresql/extract/port.go- Port extraction logicLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Test on AL2023:
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.