fix plugin checkstyle issues

shruti0085 · shruti0085 · commit 30513462b4f6 · 2024-09-26T14:10:43.000-07:00
diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/manager/DefaultLspManager.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/manager/DefaultLspManager.java
@@ -60,7 +60,7 @@ public LspInstallation getLspInstallation() {
         }
     }
 
-    private static void makeExecutable(final Path filePath, PluginPlatform platform) throws IOException {
+    private static void makeExecutable(final Path filePath, final PluginPlatform platform) throws IOException {
         // don't set file permissions for windows as it has issues using the executable
         // otherwise
         if (platform == PluginPlatform.WINDOWS) {
diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQChatWebview.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQChatWebview.java
@@ -57,24 +57,25 @@ public Object function(final Object[] arguments) {
     }
 
     private String getContent() {
-    	String jsFile = PluginUtils.getAwsDirectory(LspConstants.LSP_SUBDIRECTORY).resolve("amazonq-ui.js").toString();
+        String jsFile = PluginUtils.getAwsDirectory(LspConstants.LSP_SUBDIRECTORY).resolve("amazonq-ui.js").toString();
         var jsParent = Path.of(jsFile).getParent();
         var jsDirectoryPath = Path.of(jsParent.toUri()).normalize().toString();
-       
+
         server = setupVirtualServer(jsDirectoryPath);
         if (server == null) {
-        	return "Failed to load JS";
+            return "Failed to load JS";
         }
-        
-        var chatJsPath = server.getURI().toString()+"amazonq-ui.js";
+
+        var chatJsPath = server.getURI().toString() + "amazonq-ui.js";
         return String.format("<!DOCTYPE html>\n"
                 + "<html lang=\"en\">\n"
                 + "<head>\n"
                 + "    <meta charset=\"UTF-8\">\n"
                 + "    <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n"
                 + "    <meta \n"
                 + "          http-equiv=\"\"Content-Security-Policy\"\" \n"
-                + "          content=\"\"default-src 'none'; script-src %s 'unsafe-inline'; style-src {javascriptFilePath} 'unsafe-inline'; img-src 'self' data:; object-src 'none'; base-uri 'none'; upgrade-insecure-requests;\"\"\n"
+                + "          content=\"\"default-src 'none'; script-src %s 'unsafe-inline'; style-src {javascriptFilePath} 'unsafe-inline';"
+                + " img-src 'self' data:; object-src 'none'; base-uri 'none'; upgrade-insecure-requests;\"\"\n"
                 + "        >"
                 + "    <title>Chat UI</title>\n"
                 + "    %s\n"
@@ -129,11 +130,10 @@ protected final void handleAuthStatusChange(final boolean isLoggedIn) {
             }
         });
     }
-    
+
     @Override
-    public void dispose() {
+    public final void dispose() {
         stopVirtualServer(server);
         super.dispose();
     }
-
 }
diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQView.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQView.java
@@ -111,18 +111,17 @@ private void setupAuthStatusListeners() {
     }
 
     /**
-     * Sets up virtual host mapping for the given path using jetty server
-     * 
+     * Sets up virtual host mapping for the given path using Jetty server.
      * @param jsPath
      * @return server launched
      */
-    protected Server setupVirtualServer(String jsPath) {
+    protected Server setupVirtualServer(final String jsPath) {
         Server server = null;
         try {
             server = new Server(0);
             var servletContext = new ContextHandler();
             servletContext.setContextPath("/");
-            servletContext.addVirtualHosts(new String[] { "localhost" });
+            servletContext.addVirtualHosts(new String[] {"localhost"});
 
             var handler = new ResourceHandler();
 
@@ -143,7 +142,7 @@ protected Server setupVirtualServer(String jsPath) {
         }
     }
 
-    protected void stopVirtualServer(Server server) {
+    protected final void stopVirtualServer(final Server server) {
         if (server != null) {
             try {
                 server.stop();
diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ToolkitLoginWebview.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ToolkitLoginWebview.java
@@ -57,7 +57,7 @@ protected void handleAuthStatusChange(final boolean isLoggedIn) {
         Display.getDefault().asyncExec(() -> {
             amazonQCommonActions.updateActionVisibility(isLoggedIn, getViewSite());
             if (!isLoggedIn) {
-            	browser.setText(getContent());
+                browser.setText(getContent());
             } else {
                 browser.setText("Signed in");
                 AmazonQView.showView(AmazonQChatWebview.ID);
@@ -70,13 +70,13 @@ private String getContent() {
             URL jsFile = PluginUtils.getResource("webview/build/assets/js/getStart.js");
             var jsParent = Path.of(jsFile.toURI()).getParent();
             var jsDirectoryPath = Path.of(jsParent.toUri()).normalize().toString();
-           
+
             server = setupVirtualServer(jsDirectoryPath);
             if (server == null) {
-            	return "Failed to load JS";
+                return "Failed to load JS";
             }
-            var loginJsPath = server.getURI().toString()+"getStart.js";
-        
+            var loginJsPath = server.getURI().toString() + "getStart.js";
+
             return String.format("<!DOCTYPE html>\n"
                     + "<html>\n"
                     + "    <head>\n"
@@ -101,7 +101,7 @@ private String getContent() {
             return "Failed to load JS";
         }
     }
-    
+
     @Override
     public void dispose() {
         stopVirtualServer(server);

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public LspInstallation getLspInstallation() {`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`- private static void makeExecutable(final Path filePath, PluginPlatform platform) throws IOException {`
	`63`	`+ private static void makeExecutable(final Path filePath, final PluginPlatform platform) throws IOException {`
`64`	`64`	`// don't set file permissions for windows as it has issues using the executable`
`65`	`65`	`// otherwise`
`66`	`66`	`if (platform == PluginPlatform.WINDOWS) {`