From 8ac51f091b077d43a65a00605c8a1abfbccefc3d Mon Sep 17 00:00:00 2001 From: Nicolas Borges Date: Tue, 28 Jan 2025 18:08:38 -0500 Subject: [PATCH] checkstyle edits --- .../amazonq/views/AmazonQViewContainer.java | 10 +++--- .../amazonq/views/BaseAmazonQView.java | 6 ++-- .../amazonq/views/CallToActionView.java | 34 +++++++------------ .../amazonq/views/ChatAssetMissingView.java | 2 +- 4 files changed, 22 insertions(+), 30 deletions(-) diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQViewContainer.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQViewContainer.java index 424b5f6c..1db88790 100644 --- a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQViewContainer.java +++ b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQViewContainer.java @@ -20,7 +20,7 @@ import software.aws.toolkits.eclipse.amazonq.views.router.ViewId; -public class AmazonQViewContainer extends ViewPart implements EventObserver { +public final class AmazonQViewContainer extends ViewPart implements EventObserver { private Composite parentComposite; private StackLayout layout; private Map views; @@ -44,7 +44,7 @@ public AmazonQViewContainer() { * 2. viewContainer.init(currentView) */ - public void initializeViews(ViewId currentActiveViewId) { + public void initializeViews(final ViewId currentActiveViewId) { //init map containing all views var dependencyMissingView = new DependencyMissingView(); @@ -60,7 +60,7 @@ public void initializeViews(ViewId currentActiveViewId) { activeView = views.get(currentActiveViewId); } - public final void createPartControl(final Composite parent) { + public void createPartControl(final Composite parent) { parentComposite = parent; layout = new StackLayout(); parent.setLayout(layout); @@ -86,7 +86,7 @@ private void setupStaticMenuActions() { new AmazonQStaticActions(getViewSite()); } - private void updateChildView(BaseAmazonQView newView, ViewId newViewId) { + private void updateChildView(final BaseAmazonQView newView, final ViewId newViewId) { Display.getDefault().asyncExec(() -> { if (activeView != null) { @@ -123,7 +123,7 @@ public void onEvent(final ViewId newViewId) { } @Override - public final void setFocus() { + public void setFocus() { parentComposite.setFocus(); } diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/BaseAmazonQView.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/BaseAmazonQView.java index 6e3de5fe..4886774f 100644 --- a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/BaseAmazonQView.java +++ b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/BaseAmazonQView.java @@ -6,7 +6,7 @@ import org.eclipse.swt.widgets.Composite; public interface BaseAmazonQView { - public Composite setupView(Composite parentComposite); - public boolean canDisplay(); - public void dispose(); + Composite setupView(Composite parentComposite); + boolean canDisplay(); + void dispose(); } diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CallToActionView.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CallToActionView.java index 39efcae8..c7448510 100644 --- a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CallToActionView.java +++ b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CallToActionView.java @@ -23,9 +23,9 @@ public abstract class CallToActionView implements BaseAmazonQView { private String buttonLabel; private SelectionListener buttonHandler; - private final String ICON_PATH = getIconPath(); - private final String HEADER_LABEL = getHeaderLabel(); - private final String DETAIL_MESSAGE = getDetailMessage(); + private final String iconPath = getIconPath(); + private final String headerLabel = getHeaderLabel(); + private final String detailMessage = getDetailMessage(); private Image icon; protected abstract String getButtonLabel(); @@ -33,7 +33,7 @@ public abstract class CallToActionView implements BaseAmazonQView { protected abstract void setupButtonFooterContent(Composite composite); @Override - public Composite setupView(Composite parentComposite) { + public final Composite setupView(final Composite parentComposite) { Composite container = new Composite(parentComposite, SWT.NONE); GridLayout layout = new GridLayout(1, false); layout.marginWidth = 10; @@ -44,7 +44,7 @@ public Composite setupView(Composite parentComposite) { container.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, true)); Label iconLabel = new Label(container, SWT.NONE); - icon = loadImage(ICON_PATH); + icon = loadImage(iconPath); if (icon != null) { iconLabel.setImage(icon); iconLabel.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, false)); @@ -56,12 +56,12 @@ public Composite setupView(Composite parentComposite) { }); } - Label headerLabel = new Label(container, SWT.CENTER | SWT.WRAP); - headerLabel.setText(HEADER_LABEL); - headerLabel.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false)); + Label header = new Label(container, SWT.CENTER | SWT.WRAP); + header.setText(headerLabel); + header.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false)); Label detailLabel = new Label(container, SWT.CENTER | SWT.WRAP); - detailLabel.setText(DETAIL_MESSAGE); + detailLabel.setText(detailMessage); detailLabel.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false)); this.buttonLabel = getButtonLabel(); @@ -109,22 +109,14 @@ public void dispose() { // Default implementation - subclasses can override if they need to dispose of resources } + @SuppressWarnings("DesignForExtension") @Override public boolean canDisplay() { // Default implementation - subclasses should override to provide specific display logic return true; } - protected String getIconPath() { - // TODO Auto-generated method stub - return null; - } - protected String getHeaderLabel() { - // TODO Auto-generated method stub - return null; - } - protected String getDetailMessage() { - // TODO Auto-generated method stub - return null; - } + protected abstract String getIconPath(); + protected abstract String getHeaderLabel(); + protected abstract String getDetailMessage(); } diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ChatAssetMissingView.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ChatAssetMissingView.java index f050500f..12d735b8 100644 --- a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ChatAssetMissingView.java +++ b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/ChatAssetMissingView.java @@ -35,7 +35,7 @@ public ChatAssetMissingView() { } @Override - public Composite setupView(Composite parentComposite) { + public Composite setupView(final Composite parentComposite) { container = new Composite(parentComposite, SWT.NONE); GridLayout layout = new GridLayout(1, false); layout.marginWidth = 20;