Skip to content

Commit 427a3e2

Browse files
committed
metrics renaming
1 parent dc69ddb commit 427a3e2

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

cmd/aws-k8s-agent/main.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,21 +137,21 @@ func _main() int {
137137
log.Errorf("Failed to create event recorder: %s", err)
138138
log.Warn("Skipping event recorder initialization")
139139
}
140-
// Measure AWS initialization duration
141-
awsStartTime := time.Now()
140+
// Measure node initialization duration
141+
IPAMDNodeInitStartTime := time.Now()
142142
ipamContext, err := ipamd.New(k8sClient, withApiServer)
143-
awsDuration := time.Since(awsStartTime).Seconds()
143+
IPAMDNodeInitDuration := time.Since(IPAMDNodeInitStartTime).Seconds()
144144

145145
if err != nil {
146146
log.Errorf("Initialization failure: %v", err)
147-
// Record failed AWS initialization and failed startup
148-
metrics.IpamdStartupAwsDuration.WithLabelValues("false").Observe(awsDuration)
149-
metrics.IpamdStartupDuration.WithLabelValues("false", strconv.FormatBool(withApiServer), "aws_initialization").Observe(time.Since(startupStartTime).Seconds())
147+
// Record failed IPAMD initialization and failed startup
148+
metrics.IpamdNodeInitDuration.WithLabelValues("false").Observe(IPAMDNodeInitDuration)
149+
metrics.IpamdStartupDuration.WithLabelValues("false", strconv.FormatBool(withApiServer), "node_initialization").Observe(time.Since(startupStartTime).Seconds())
150150
return 1
151151
}
152152

153153
// Record successful AWS initialization
154-
metrics.IpamdStartupAwsDuration.WithLabelValues("true").Observe(awsDuration)
154+
metrics.IpamdNodeInitDuration.WithLabelValues("true").Observe(IPAMDNodeInitDuration)
155155

156156
// If not connected to API server yet, start background checks
157157
if !withApiServer {

utils/prometheusmetrics/prometheusmetrics.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,10 @@ var (
179179
},
180180
[]string{"success", "with_api_server", "failure_reason"},
181181
)
182-
IpamdStartupAwsDuration = prometheus.NewHistogramVec(
182+
IpamdNodeInitDuration = prometheus.NewHistogramVec(
183183
prometheus.HistogramOpts{
184-
Name: "awscni_ipamd_startup_aws_duration_seconds",
185-
Help: "The duration of AWS initialization during IPAMD startup",
184+
Name: "awscni_ipamd_node_initialization_duration_seconds",
185+
Help: "The duration of node initialization during IPAMD startup",
186186
},
187187
[]string{"success"},
188188
)
@@ -240,7 +240,7 @@ func PrometheusRegister() {
240240
prometheus.MustRegister(NoAvailableIPAddrs)
241241
prometheus.MustRegister(EniIPsInUse)
242242
prometheus.MustRegister(IpamdStartupDuration)
243-
prometheus.MustRegister(IpamdStartupAwsDuration)
243+
prometheus.MustRegister(IpamdNodeInitDuration)
244244
}
245245

246246
// This can be enhanced to get it programatically.

0 commit comments

Comments
 (0)