Skip to content

Commit 13e9d1b

Browse files
author
Maharaj Haider
committed
renamed featureflag
resolved merge conflict resolved merge conflicts
1 parent 0241e0e commit 13e9d1b

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2127,6 +2127,24 @@ The new behavior from this feature will allow a user, for example, to set 1 of t
21272127
| V2NEXT | `false` | `true` |
21282128

21292129

2130+
### @aws-cdk/aws-s3:publicAccessBlockedByDefault
2131+
2132+
*When enabled, setting any combination of options for BlockPublicAccess will automatically set true for any options not defined.*
2133+
2134+
Flag type: Backwards incompatible bugfix
2135+
2136+
When BlockPublicAccess is not set at all, s3's default behavior will be to set all options to true in aws console.
2137+
The previous behavior in cdk before this feature was; if only some of the BlockPublicAccessOptions were set (not all 4), then the ones undefined would default to false.
2138+
This is counter intuitive to the console behavior where the options would start in true state and a user would uncheck the boxes as needed.
2139+
The new behavior from this feature will allow a user, for example, to set 1 of the 4 BlockPublicAccessOpsions to false, and on deployment the other 3 will remain true.
2140+
2141+
2142+
| Since | Default | Recommended |
2143+
| ----- | ----- | ----- |
2144+
| (not in v1) | | |
2145+
| V2NEXT | `false` | `true` |
2146+
2147+
21302148
### @aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway
21312149

21322150
*When enabled, the EgressOnlyGateway resource is only created if private subnets are defined in the dual-stack VPC.*

packages/aws-cdk-lib/recommended-feature-flags.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,6 @@
7272
"@aws-cdk/aws-dynamodb:retainTableReplica": true,
7373
"@aws-cdk/aws-stepfunctions:useDistributedMapResultWriterV2": true,
7474
"@aws-cdk/s3-notifications:addS3TrustKeyPolicyForSnsSubscriptions": true,
75-
"@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true,
76-
"@aws-cdk/aws-s3:publicAccessBlockedByDefault": true
75+
"@aws-cdk/aws-s3:publicAccessBlockedByDefault": true,
76+
"@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true
7777
}

0 commit comments

Comments
 (0)