feat(globalaccelerator): throw typed errors

Author: mrgrain

packages/aws-cdk-lib/.eslintrc.js

@@ -20,8 +20,6 @@ const noThrowDefaultErrorNotYetSupported = [
   'aws-ecs-patterns',
   'aws-ecs',
   'aws-elasticsearch',
-  'aws-globalaccelerator',
-  'aws-globalaccelerator-endpoints',
   'aws-iam',
   'aws-lambda-destinations',
   'aws-lambda-event-sources',

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/_util.ts

@@ -1,7 +1,8 @@
-import { Token } from '../../core';
+import { IConstruct } from 'constructs';
+import { Token, ValidationError } from '../../core';
 
-export function validateWeight(x?: number) {
+export function validateWeight(scope: IConstruct, x?: number) {
   if (x !== undefined && !Token.isUnresolved(x) && (x < 0 || x > 255)) {
-    throw new Error(`'weight' must be between 0 and 255, got: ${x}`);
+    throw new ValidationError(`'weight' must be between 0 and 255, got: ${x}`, scope);
   }
 }

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/alb.ts

@@ -36,7 +36,7 @@ export class ApplicationLoadBalancerEndpoint implements ga.IEndpoint {
   public readonly region?: string;
 
   constructor(private readonly loadBalancer: elbv2.IApplicationLoadBalancer, private readonly options: ApplicationLoadBalancerEndpointOptions = {}) {
-    validateWeight(options.weight);
+    validateWeight(loadBalancer, options.weight);
     this.region = loadBalancer.env.region;
   }
 

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/eip.ts

@@ -24,7 +24,7 @@ export class CfnEipEndpoint implements ga.IEndpoint {
   public readonly region?: string;
 
   constructor(private readonly eip: ec2.CfnEIP, private readonly options: CfnEipEndpointProps = {}) {
-    validateWeight(options.weight);
+    validateWeight(eip, options.weight);
 
     this.region = Stack.of(eip).region;
   }

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/instance.ts

@@ -36,7 +36,7 @@ export class InstanceEndpoint implements ga.IEndpoint {
   public readonly region?: string;
 
   constructor(private readonly instance: ec2.IInstance, private readonly options: InstanceEndpointProps = {}) {
-    validateWeight(options.weight);
+    validateWeight(instance, options.weight);
 
     this.region = instance.env.region;
   }

packages/aws-cdk-lib/aws-globalaccelerator-endpoints/lib/nlb.ts

@@ -36,7 +36,7 @@ export class NetworkLoadBalancerEndpoint implements ga.IEndpoint {
   public readonly region?: string;
 
   constructor(private readonly loadBalancer: elbv2.INetworkLoadBalancer, private readonly options: NetworkLoadBalancerEndpointProps = {}) {
-    validateWeight(options.weight);
+    validateWeight(loadBalancer, options.weight);
     this.region = loadBalancer.env.region;
   }
 

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts

@@ -225,13 +225,13 @@ export class Accelerator extends cdk.Resource implements IAccelerator {
 
   private validateAcceleratorName(name?: string) {
     if (!cdk.Token.isUnresolved(name) && name !== undefined && (name.length < 1 || name.length > 64)) {
-      throw new Error(`Invalid acceleratorName value ${name}, must have length between 1 and 64, got: ${name.length}`);
+      throw new cdk.ValidationError(`Invalid acceleratorName value ${name}, must have length between 1 and 64, got: ${name.length}`, this);
     }
   }
 
   private validateIpAddresses(ipAddresses?: string[]) {
     if (ipAddresses !== undefined && (ipAddresses.length < 1 || ipAddresses.length > 2)) {
-      throw new Error(`Invalid ipAddresses value [${ipAddresses}], you can specify one or two addresses, got: ${ipAddresses.length}`);
+      throw new cdk.ValidationError(`Invalid ipAddresses value [${ipAddresses}], you can specify one or two addresses, got: ${ipAddresses.length}`, this);
     }
   }
 }