Skip to content

Commit 545e5ff

Browse files
TietewTietew
committed
update tests
1 parent 563ae66 commit 545e5ff

File tree

1 file changed

+50
-64
lines changed

1 file changed

+50
-64
lines changed

Diff for: ‎packages/aws-cdk-lib/aws-rds/test/cluster-engine.test.ts

+50-64
Original file line numberDiff line numberDiff line change
@@ -35,58 +35,6 @@ describe('cluster engine', () => {
3535
expect(family).toEqual(undefined);
3636
});
3737

38-
testDeprecated('cluster parameter group correctly determined for AURORA and given version', () => {
39-
// GIVEN
40-
const engine = DatabaseClusterEngine.aurora({
41-
version: AuroraEngineVersion.VER_1_22_2,
42-
});
43-
44-
// WHEN
45-
const family = engine.parameterGroupFamily;
46-
47-
// THEN
48-
expect(family).toEqual('aurora5.6');
49-
});
50-
51-
test('cluster parameter group correctly determined for AURORA_MYSQL and given version', () => {
52-
// GIVEN
53-
const engine = DatabaseClusterEngine.auroraMysql({
54-
version: AuroraMysqlEngineVersion.VER_2_12_3,
55-
});
56-
57-
// WHEN
58-
const family = engine.parameterGroupFamily;
59-
60-
// THEN
61-
expect(family).toEqual('aurora-mysql5.7');
62-
});
63-
64-
test('cluster parameter group correctly determined for AURORA_MYSQL and given version 3', () => {
65-
// GIVEN
66-
const engine = DatabaseClusterEngine.auroraMysql({
67-
version: AuroraMysqlEngineVersion.VER_3_07_1,
68-
});
69-
70-
// WHEN
71-
const family = engine.parameterGroupFamily;
72-
73-
// THEN
74-
expect(family).toEqual('aurora-mysql8.0');
75-
});
76-
77-
test('cluster parameter group correctly determined for AURORA_POSTGRESQL and given version', () => {
78-
// GIVEN
79-
const engine = DatabaseClusterEngine.auroraPostgres({
80-
version: AuroraPostgresEngineVersion.VER_16_3,
81-
});
82-
83-
// WHEN
84-
const family = engine.parameterGroupFamily;
85-
86-
// THEN
87-
expect(family).toEqual('aurora-postgresql16');
88-
});
89-
9038
test('parameter group family', () => {
9139
// the PostgreSQL engine knows about the following major versions: 9.6, 10 and 11
9240

@@ -120,11 +68,25 @@ describe('cluster engine', () => {
12068
expect(DatabaseClusterEngine.auroraPostgres({ version: AuroraPostgresEngineVersion.VER_16_3 }).supportedLogTypes).toEqual(['postgresql']);
12169
});
12270

123-
test('cluster parameter group correctly determined for AURORA_POSTGRESQL 14 (and other) and given version', () => {
71+
test('cluster parameter group correctly determined for AURORA_POSTGRESQL and given version', () => {
12472
// GIVEN
12573
const engine_VER_14_3 = DatabaseClusterEngine.auroraPostgres({
12674
version: AuroraPostgresEngineVersion.VER_14_3,
12775
});
76+
const engine_VER_16_3 = DatabaseClusterEngine.auroraPostgres({
77+
version: AuroraPostgresEngineVersion.VER_16_3,
78+
});
79+
80+
// THEN
81+
expect(engine_VER_14_3.parameterGroupFamily).toEqual('aurora-postgresql14');
82+
expect(engine_VER_16_3.parameterGroupFamily).toEqual('aurora-postgresql16');
83+
});
84+
85+
testDeprecated('cluster parameter group correctly determined for AURORA and given version', () => {
86+
// GIVEN
87+
const engine_ver_1_22_2 = DatabaseClusterEngine.aurora({
88+
version: AuroraEngineVersion.VER_1_22_2,
89+
});
12890
const engine_ver_1_22_3 = DatabaseClusterEngine.aurora({
12991
version: AuroraEngineVersion.VER_1_22_3,
13092
});
@@ -134,6 +96,16 @@ describe('cluster engine', () => {
13496
const engine_ver_1_22_5 = DatabaseClusterEngine.aurora({
13597
version: AuroraEngineVersion.VER_1_22_5,
13698
});
99+
100+
// THEN
101+
expect(engine_ver_1_22_2.parameterGroupFamily).toEqual('aurora5.6');
102+
expect(engine_ver_1_22_3.parameterGroupFamily).toEqual('aurora5.6');
103+
expect(engine_ver_1_22_4.parameterGroupFamily).toEqual('aurora5.6');
104+
expect(engine_ver_1_22_5.parameterGroupFamily).toEqual('aurora5.6');
105+
});
106+
107+
test('cluster parameter group correctly determined for AURORA_MYSQL 2.x and given version', () => {
108+
// GIVEN
137109
const engine_ver_2_7_3 = DatabaseClusterEngine.auroraMysql({
138110
version: AuroraMysqlEngineVersion.VER_2_07_3,
139111
});
@@ -161,21 +133,14 @@ describe('cluster engine', () => {
161133
const engine_ver_2_11_3 = DatabaseClusterEngine.auroraMysql({
162134
version: AuroraMysqlEngineVersion.VER_2_11_3,
163135
});
164-
const engine_ver_3_07_1 = DatabaseClusterEngine.auroraMysql({
165-
version: AuroraMysqlEngineVersion.VER_3_07_1,
166-
});
167-
const engine_ver_3_08_0 = DatabaseClusterEngine.auroraMysql({
168-
version: AuroraMysqlEngineVersion.VER_3_08_0,
136+
const engine_ver_2_12_3 = DatabaseClusterEngine.auroraMysql({
137+
version: AuroraMysqlEngineVersion.VER_2_12_3,
169138
});
170-
const engine_ver_3_08_1 = DatabaseClusterEngine.auroraMysql({
171-
version: AuroraMysqlEngineVersion.VER_3_08_1,
139+
const engine_ver_2_12_4 = DatabaseClusterEngine.auroraMysql({
140+
version: AuroraMysqlEngineVersion.VER_2_12_4,
172141
});
173142

174143
// THEN
175-
expect(engine_VER_14_3.parameterGroupFamily).toEqual('aurora-postgresql14');
176-
expect(engine_ver_1_22_3.parameterGroupFamily).toEqual('aurora5.6');
177-
expect(engine_ver_1_22_4.parameterGroupFamily).toEqual('aurora5.6');
178-
expect(engine_ver_1_22_5.parameterGroupFamily).toEqual('aurora5.6');
179144
expect(engine_ver_2_7_3.parameterGroupFamily).toEqual('aurora-mysql5.7');
180145
expect(engine_ver_2_7_4.parameterGroupFamily).toEqual('aurora-mysql5.7');
181146
expect(engine_ver_2_7_5.parameterGroupFamily).toEqual('aurora-mysql5.7');
@@ -185,8 +150,29 @@ describe('cluster engine', () => {
185150
expect(engine_ver_2_8_3.parameterGroupFamily).toEqual('aurora-mysql5.7');
186151
expect(engine_ver_2_8_4.parameterGroupFamily).toEqual('aurora-mysql5.7');
187152
expect(engine_ver_2_11_3.parameterGroupFamily).toEqual('aurora-mysql5.7');
153+
expect(engine_ver_2_12_3.parameterGroupFamily).toEqual('aurora-mysql5.7');
154+
expect(engine_ver_2_12_4.parameterGroupFamily).toEqual('aurora-mysql5.7');
155+
});
156+
157+
test('cluster parameter group correctly determined for AURORA_MYSQL 3.x and given version', () => {
158+
// GIVEN
159+
const engine_ver_3_07_1 = DatabaseClusterEngine.auroraMysql({
160+
version: AuroraMysqlEngineVersion.VER_3_07_1,
161+
});
162+
const engine_ver_3_08_0 = DatabaseClusterEngine.auroraMysql({
163+
version: AuroraMysqlEngineVersion.VER_3_08_0,
164+
});
165+
const engine_ver_3_08_1 = DatabaseClusterEngine.auroraMysql({
166+
version: AuroraMysqlEngineVersion.VER_3_08_1,
167+
});
168+
const engine_ver_3_08_2 = DatabaseClusterEngine.auroraMysql({
169+
version: AuroraMysqlEngineVersion.VER_3_08_2,
170+
});
171+
172+
// THEN
188173
expect(engine_ver_3_07_1.parameterGroupFamily).toEqual('aurora-mysql8.0');
189174
expect(engine_ver_3_08_0.parameterGroupFamily).toEqual('aurora-mysql8.0');
190175
expect(engine_ver_3_08_1.parameterGroupFamily).toEqual('aurora-mysql8.0');
176+
expect(engine_ver_3_08_2.parameterGroupFamily).toEqual('aurora-mysql8.0');
191177
});
192178
});

0 commit comments

Comments
 (0)