Skip to content

Commit 6754b0e

Browse files
committed
fix: getter method name
1 parent a576189 commit 6754b0e

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

packages/aws-cdk-lib/aws-codebuild/lib/project.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,6 @@ abstract class ProjectBase extends Resource implements IProject {
275275
*/
276276
protected _connections: ec2.Connections | undefined;
277277

278-
/**
279-
* Actual value will be determined for a Project
280-
* using a getter depending on the effect of enableBatchBuilds
281-
*/
282-
public readonly isBatchBuildEnabled = false;
283-
284278
/**
285279
* Access the Connections object.
286280
* Will fail if this Project does not have a VPC set.
@@ -292,6 +286,14 @@ abstract class ProjectBase extends Resource implements IProject {
292286
return this._connections;
293287
}
294288

289+
/**
290+
* Actual value will be determined for a Project
291+
* using a getter depending on the effect of enableBatchBuilds
292+
*/
293+
public get isBatchBuildEnabled(): boolean {
294+
return false;
295+
}
296+
295297
public enableBatchBuilds(): BatchBuildConfig | undefined {
296298
return undefined;
297299
}
@@ -1220,7 +1222,7 @@ export class Project extends ProjectBase {
12201222
this.node.addValidation({ validate: () => this.validateProject() });
12211223
}
12221224

1223-
public get isBatchBuildsEnabled(): boolean {
1225+
public get isBatchBuildEnabled(): boolean {
12241226
return !!this._batchServiceRole;
12251227
}
12261228

packages/aws-cdk-lib/aws-codebuild/test/codebuild.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2104,13 +2104,13 @@ test('enableBatchBuilds()', () => {
21042104
repo: 'testrepo',
21052105
}),
21062106
});
2107-
expect(project.isBatchBuildsEnabled).toBeFalsy();
2107+
expect(project.isBatchBuildEnabled).toBeFalsy();
21082108

21092109
const returnVal = project.enableBatchBuilds();
21102110
if (!returnVal?.role) {
21112111
throw new Error('Expecting return value with role');
21122112
}
2113-
expect(project.isBatchBuildsEnabled).toBeTruthy();
2113+
expect(project.isBatchBuildEnabled).toBeTruthy();
21142114

21152115
Template.fromStack(stack).hasResourceProperties('AWS::CodeBuild::Project', {
21162116
BuildBatchConfig: {

0 commit comments

Comments
 (0)