Skip to content

Commit e45ac63

Browse files
author
Maharaj Haider
committed
renamed featureflag
resolved merge conflict resolved merge conflicts
1 parent 7c20d4c commit e45ac63

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2108,7 +2108,6 @@ When this feature flag is enabled, a S3 trust policy will be added to the KMS ke
21082108
| (not in v1) | | |
21092109
| 2.195.0 | `false` | `true` |
21102110

2111-
21122111
### @aws-cdk/aws-s3:publicAccessBlockedByDefault
21132112

21142113
*When enabled, setting any combination of options for BlockPublicAccess will automatically set true for any options not defined.*
@@ -2127,34 +2126,6 @@ The new behavior from this feature will allow a user, for example, to set 1 of t
21272126
| V2NEXT | `false` | `true` |
21282127

21292128

2130-
### @aws-cdk/aws-s3:publicAccessBlockedByDefault
2131-
2132-
*When enabled, setting any combination of options for BlockPublicAccess will automatically set true for any options not defined.*
2133-
2134-
Flag type: Backwards incompatible bugfix
2135-
2136-
When BlockPublicAccess is not set at all, s3's default behavior will be to set all options to true in aws console.
2137-
The previous behavior in cdk before this feature was; if only some of the BlockPublicAccessOptions were set (not all 4), then the ones undefined would default to false.
2138-
This is counter intuitive to the console behavior where the options would start in true state and a user would uncheck the boxes as needed.
2139-
The new behavior from this feature will allow a user, for example, to set 1 of the 4 BlockPublicAccessOpsions to false, and on deployment the other 3 will remain true.
2140-
2141-
2142-
| Since | Default | Recommended |
2143-
| ----- | ----- | ----- |
2144-
| (not in v1) | | |
2145-
| V2NEXT | `false` | `true` |
2146-
2147-
2148-
### @aws-cdk/aws-s3:publicAccessBlockedByDefault
2149-
2150-
*When enabled, setting any combination of options for BlockPublicAccess will automatically set true for any options not defined.*
2151-
2152-
Flag type: Backwards incompatible bugfix
2153-
2154-
When BlockPublicAccess is not set at all, s3's default behavior will be to set all options to true in aws console.
2155-
The previous behavior in cdk before this feature was; if only some of the BlockPublicAccessOptions were set (not all 4), then the ones undefined would default to false.
2156-
This is counter intuitive to the console behavior where the options would start in true state and a user would uncheck the boxes as needed.
2157-
The new behavior from this feature will allow a user, for example, to set 1 of the 4 BlockPublicAccessOpsions to false, and on deployment the other 3 will remain true.
21582129
### @aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway
21592130

21602131
*When enabled, the EgressOnlyGateway resource is only created if private subnets are defined in the dual-stack VPC.*

packages/aws-cdk-lib/recommended-feature-flags.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,6 @@
7272
"@aws-cdk/aws-dynamodb:retainTableReplica": true,
7373
"@aws-cdk/aws-stepfunctions:useDistributedMapResultWriterV2": true,
7474
"@aws-cdk/s3-notifications:addS3TrustKeyPolicyForSnsSubscriptions": true,
75-
"@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true,
76-
"@aws-cdk/aws-s3:publicAccessBlockedByDefault": true
75+
"@aws-cdk/aws-s3:publicAccessBlockedByDefault": true,
76+
"@aws-cdk/aws-ec2:requirePrivateSubnetsForEgressOnlyInternetGateway": true
7777
}

0 commit comments

Comments
 (0)