feat(cloudwatch): add contributor insights widget #13008
Conversation
This adds a ContributorInsightsWidget to show data from Contributor Insights rules. This was a feature supported by the console but not the CDK so far. This closes aws#13005
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudwatch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| /** | ||
| * Insights rule to display | ||
| */ | ||
| readonly ruleName: string; |
There was a problem hiding this comment.
Is an "insights rule" a resource that is created independently?
In that case, referencing it should follow the same rules as referencing other AWS resources: we don't accept buckets as bucketName: string, we accept bucket as bucket: IBucket.
By that same token, we're probably going to need an IInsightRule and an InsightRule.fromInsightRuleName() to produce one.
You could go as far as completely fill out the L2 for AWS::CloudWatch::InsightRule but I will accept an abstract class that only allows importing existing insight rules as a minimal delta from what we have, to move this PR forward.
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
rix0rrr
added
feature-request
|
This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error. |
This adds a ContributorInsightsWidget to show data from Contributor
Insights rules. This was a feature supported by the console but not the
CDK so far. This closes #13005
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license