Skip to content

chore(core): Print docker stdout & stderr on error #23893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

chore(core): Print docker stdout & stderr on error #23893

wants to merge 3 commits into from

Conversation

yo-ga
Copy link
Contributor

@yo-ga yo-ga commented Jan 28, 2023

Fix missing stdout and stderr when calling dockerExec

In the function dockerExec, we export the stdout and stderr when the status code is not 0. We should also export them before we throw proc.error.

Closes #20892.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 28, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 28, 2023 16:46
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 28, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@yo-ga yo-ga changed the title fix(core): Print docker stdout & stderr on error chore(core): Print docker stdout & stderr on error Jan 28, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 28, 2023 17:20

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b4d4101
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@yo-ga yo-ga closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(core): Docker stdout is not printed on error during bundling
2 participants
@yo-ga @aws-cdk-automation