fix (aws-cloudwatch): use dimensionsMap property instead of depresiated dimensions in Metric class(fixes the docs issue) #21647
Conversation
|
|
There was a problem hiding this comment.
Thank you for your contribution! We will need some tests for this change.
Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log (See Contributing Guide, Pull Requests)
Additionally, please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process.
ahzia
changed the title
Co-authored-by: Kendra Neil <[email protected]>
|
@TheRealAmazonKendra Thanks for your review, I have made some updates to the PR name and description. |
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
ahzia
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
We will want tests for this @ahzia,
In addition to this and the other comment I made, you have some issues that are throwing errors in our build that you'll need to fix
@aws-cdk/aws-cloudwatch: /codebuild/output/src931296454/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-cloudwatch/lib/metric.ts
@aws-cdk/aws-cloudwatch: 254:6 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-cloudwatch: 255:31 error Trailing spaces not allowed no-trailing-spaces
| public readonly dimensions?: DimensionHash; | ||
| /** Dimensions of this metric */ | ||
| public readonly dimensionsMap?: DimensionsMap; |
There was a problem hiding this comment.
You're creating this new prop, but not doing anything with it yet so it will always be undefined. There are a few other places where we use this.dimensions that you'll need to account for with this new prop if we are to deprecate the old prop
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
The Metric Class does not have the
dimentionsMapproperty, instead, it includes the depreciateddimensions, So in the documentation, It is not showingdimentionsMap.I added dimentionsMap into the class and documented the "dimensions" property as depreciated.
fixes #21618
All Submissions:
Adding new Unconventional Dependencies:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license