(aws-cloudformation) What is wrong with my code?

[dentistfrankchen]

Describe the bug

Here's my yaml file.
The stack cannot be created.
It says [Failure] reason
Properties validation failed for resource EC2Instance with message: [#: extraneous key [InstanceMarketOptions] is not permitted]

WindowsServer2019-NICE-DCV.yaml.txt

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Library Version

No response

Expected Behavior

The stack should be created.

Current Behavior

CREATE_ERROR

Reproduction Steps

use the yaml to create stacks.

Possible Solution

No response

Additional Information/Context

No response

AWS CDK Library version (aws-cdk-lib)

...

AWS CDK CLI version

...

Node.js Version

...

OS

...

Language

Python

Language Version

No response

Other information

No response

[ykethan]

Hey @dentistfrankchen, thank you for reaching out. Wanted to get some additional information on the use case. was the CloudFormation template generated using AWS CDK or are you currently importing an existing template into CDK?

But on diving into the provided CloudFormation template and the error message. From the CloudFormation documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-instancemarketoptions.html

it appears the InstanceMarketOptions is a property of the AWS::EC2::LaunchTemplate LaunchTemplateData. The error occurs because InstanceMarketOptions cannot be used directly with an AWS::EC2::Instance resource. This property is only valid within a Launch Template configuration.

According to AWS CloudFormation documentation, to create a Spot Instance, you need to:

1. Create a Launch Template that includes your Spot configuration
2. Reference that Launch Template from your EC2 Instance resource

while i have not deployed these changes, the changes on the template for example may require:

1. Create a new Launch Template resource with your Spot configuration:

SpotLaunchTemplate:
  Type: AWS::EC2::LaunchTemplate
  Properties:
    LaunchTemplateName: !Sub "${AWS::StackName}-spot-template"
    LaunchTemplateData:
      # All your instance configuration goes here
      ImageId: !FindInMap [AMIRegionMap, !Ref "AWS::Region", NICEDCVAMI]
      InstanceType: !Ref InstanceType
      # Other properties...
      InstanceMarketOptions:
        MarketType: spot
        SpotOptions:
          MaxPrice: !Ref SpotPrice
          InstanceInterruptionBehavior: stop

2. Modify your EC2 Instance to reference the template:

EC2Instance:
  Type: AWS::EC2::Instance
  Properties:
    LaunchTemplate:
      LaunchTemplateId: !Ref SpotLaunchTemplate
      Version: !GetAtt SpotLaunchTemplate.LatestVersionNumber
    SubnetId: !Ref PublicSubnet
# Other properties that can stay at EC2 Instance level...

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.