feat(codebuild): add ec2 image types #34365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32978.
Reason for this change
The CodeBuild CDK code needs to add new image types to match newly supported environment types:
LINUX_EC2,ARM_EC2andWINDOWS_EC2.These three imageId values were used because they are the only ones supported when launching EC2-based CodeBuild environments through both CloudFormation and the AWS API. Other image IDs resulted in errors or were not accepted for the LINUX_EC2, WINDOWS_EC2 and ARM_EC2 environment types.
aws/codebuild/ami/amazonlinux-x86_64-base:latestaws/codebuild/ami/amazonlinux-arm-base:latestaws/codebuild/ami/windows-base:2022Description of changes
Add new image types
LINUX_EC2,ARM_EC2andWINDOWS_EC2into file.Description of how you validated changes
I created unit tests and integration tests.
Both were successful.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license