Skip to content

feat(applicationsignals-alpha): introduce Application Signals SLO L2 constructs #34413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

TejeshreeDaliVenugopal
Copy link

Issue # (if applicable)

Description of changes

This PR adds L2 constructs to simplify the Application Signals slo process. See aws/aws-cdk-rfcs#673 for more details.

Description of how you validated changes

  • Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 10, 2025 00:04
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels May 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@TejeshreeDaliVenugopal TejeshreeDaliVenugopal force-pushed the dalivete-dev/application-signals-slo branch from 23d98a0 to 588dc02 Compare May 10, 2025 00:49
moelasmar added 11 commits May 9, 2025 18:24
…enablement-daemon.js.snapshot/ApplicationSignalsIntegrationECSDaemonDefaultTestDeployAssert0A2A622F.assets.json
…enablement-daemon.js.snapshot/ApplicationSignalsIntegrationECSDaemonDefaultTestDeployAssert0A2A622F.template.json
…enablement-daemon.js.snapshot/asset.a1acfc2b5f4f6b183fd2bb9863f486bc5edef6a357b355a070d9a0e502df418c/__entrypoint__.js
…enablement-daemon.js.snapshot/asset.a1acfc2b5f4f6b183fd2bb9863f486bc5edef6a357b355a070d9a0e502df418c/index.js
…enablement-daemon.js.snapshot/ecs-enablement-integration.assets.json
…enablement-daemon.js.snapshot/ecs-enablement-integration.template.json
…enablement-sidecar.js.snapshot/ApplicationSignalsIntegrationECSSidecarDefaultTestDeployAssert7F3E5290.assets.json
…enablement-sidecar.js.snapshot/ApplicationSignalsIntegrationECSSidecarDefaultTestDeployAssert7F3E5290.template.json
…enablement-sidecar.js.snapshot/ecs-enablement-integration.assets.json
…enablement-sidecar.js.snapshot/ecs-enablement-integration.template.json
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c18ee9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants