-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(globalaccelerator): throw ValidationError
s instead of untyped errors
#34426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34426 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 124 124
Lines 7009 7009
Branches 1176 1176
=======================================
Hits 5895 5895
Misses 1003 1003
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ValidationErrors
instead of untyped Errors
ValidationErrors
instead of untyped ErrorsValidationError
s instead of untyped Errors
ValidationError
s instead of untyped ErrorsValidationError
s instead of untyped errors
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
e8f8ad4
to
47811ab
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #34426 has been dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue
Relates to #32569
Reason for this change
untyped Errors are not recommended
Description of changes
ValidationError
s everywhereDescribe any new or updated permissions being added
None
Description of how you validated changes
Existing tests. Exemptions granted as this is a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license