Skip to content

feat(elasticsearch): throw ValidationErrors instead of untyped errors #34429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 12, 2025

Issue

Relates to #32569

Reason for this change

untyped Errors are not recommended

Description of changes

ValidationErrors everywhere

Describe any new or updated permissions being added

None

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 12, 2025 16:34
@github-actions github-actions bot added the p2 label May 12, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (98e352d) to head (97e51ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34429   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         124      124           
  Lines        7009     7009           
  Branches     1176     1176           
=======================================
  Hits         5895     5895           
  Misses       1003     1003           
  Partials      111      111           
Flag Coverage Δ
suite.unit 84.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 84.10% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain changed the title feat(elasticsearch): throw typed errors feat(elasticsearch): throw ValidationErrors instead of untyped errors May 12, 2025
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 12, 2025 20:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented May 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented May 12, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #34429 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mrgrain mrgrain force-pushed the mrgrain/feat/elasticsearch-no-throw-default branch from 74740f4 to 1163137 Compare May 13, 2025 07:20
@mrgrain mrgrain force-pushed the mrgrain/feat/elasticsearch-no-throw-default branch from 1163137 to 4d9950d Compare May 13, 2025 07:20
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 97e51ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 13d9645 into main May 13, 2025
21 checks passed
Copy link
Contributor

mergify bot commented May 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the mrgrain/feat/elasticsearch-no-throw-default branch May 13, 2025 08:20
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants